Remove padding on euipage breakpoint for now#282
Merged
snide merged 5 commits intoelastic:masterfrom Jan 10, 2018
Merged
Conversation
cjcenizal
approved these changes
Jan 10, 2018
Contributor
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
LGTM one nitpick about the CHANGELOG. 😝
CHANGELOG.md
Outdated
|
|
||
| **Bug fixes** | ||
|
|
||
| - Remove padding on euipage mobile breakpoint. [(#282)](https://github.com/elastic/eui/pull/282) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #281
The responsive breakpoint we have set up works fine in EUI because page assumes it's flush against the browser sides, but Kibana isn't quite there yet. This change adds the padding back, which will play nicer with Kibana and only operate slightly worse for native EUI pages.