Single page pagination, button reset, table header sorting, codeblock styling#298
Single page pagination, button reset, table header sorting, codeblock styling#298snide merged 6 commits intoelastic:masterfrom
Conversation
|
Was there an idea to also disable the Previous/Next pagination links instead of removing them? |
| @@ -75,7 +75,8 @@ | |||
| display: inline-block; | |||
There was a problem hiding this comment.
If you remove vertical-align: middle from .euiCodeBlock--inline it will align it to the baseline.
| white-space: pre; | ||
| color: $euiTextColor; | ||
| font-size: 75%; // 1 | ||
| font-size: 90%; // 1 |
There was a problem hiding this comment.
I like that it's still slightly smaller, but this is a much better scale.
src/global_styling/reset/_reset.scss
Outdated
| color: inherit; | ||
| font-size: inherit; | ||
| border-radius: 0; | ||
| text-align: left; |
There was a problem hiding this comment.
Does this have any ill cascading effects?
There was a problem hiding this comment.
It doesn't in EUI, but it might in the nest of Kibana. I'm gonna move it over to EuiLink which was the primary sore spot (that onClick turns EuiLink into buttons, which shouldn't have alignment). That's probably safer.
|
@cchaos Addressed. |
|
Any thoughts on my previous comment or leave that for another PR? |
|
Can we find a way to visually communicate that a column is sortable or not? It kind of sucks for the user to need to hover on something to find out whether it's clickable. Better to know something is clickable before you try to click it. |
|
Or maybe we can find a way to visually communicate the column is not sortable. Maybe by graying out the column name slightly? |
|
@cjcenizal We talked about it a bunch #268 and finalized on hover being the indicator. But your second idea could help as well – just a slightly lighter gray header. Not sure it's necessary for this PR. |
|
Talked over slack. Merging for now, but no one is super happy with the header styles. We'll need to fix that later. @cchaos we'll also deal with the separate pagination issue later. Feel free to set up a PR on that if you have ideas. |
3 participants
Fixes #297, #268 and #289, #300, #299
Small stylistic changes.
Pagination no long shows a single item
Table heads no longer show vague "is sortable" state. Things just have hover states or not. Only one sort shows.
Codeblock sizing increasing with additional padding per feedback form designers