Reorder selectors to fix fixed progress bar in Firefox#404
Merged
jen-huang merged 2 commits intoelastic:masterfrom Feb 14, 2018
Merged
Reorder selectors to fix fixed progress bar in Firefox#404jen-huang merged 2 commits intoelastic:masterfrom
jen-huang merged 2 commits intoelastic:masterfrom
Conversation
snide
approved these changes
Feb 14, 2018
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
Tested and works. Do you mind adding a bug fix line to the https://github.com/elastic/eui/blob/master/CHANGELOG.md before merging?
Contributor
Author
|
@snide Done! |
Contributor
|
@jen-huang Great. Thanks for the fix! Safe to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362
Issue had to do with
background-color: transparent;of fixed style taking precedence over color styles:Fix simply reorders the styles: