Clean up EuiSearchBar docs and reorganize code.#454
Conversation
cjcenizal
commented
Feb 26, 2018
cjcenizal
commented
- Move Query to services.
- Change random.oneOf to accept an array.
cjcenizal
force-pushed
the
search-bar-docs
branch
2 times, most recently
from
625f357 to
c7d4a35
Compare
- Rename AST to Ast and astToES to astToEs to maintain consistent naming convention. - Fix enzyme imports. - Move Query to services. - Publish Ast and Query services. - Change random.oneOf to accept an array.
cjcenizal
force-pushed
the
search-bar-docs
branch
from
c7d4a35 to
945b6ca
Compare
|
Tests passed locally, looks like the failures are on Jenkins's side. |
|
CC @uboness made some changes here to some of the code you contributed, in case you're curious. I think these changes are non-controversial so I'm going to go ahead and merge. |
|
I wouldn't have moved query to services... because it was built for the search bar... But if you really want it there go for it... I'd change the name though because it's fairly generic name and there'll be other query languages in kibana, associating it with the search bar avoided that... I actually have (now had) another pr to actually expose it as a static field on the search bar component itself |
|
actually... I'd appreciate it if you revert this changes... I have quite a big PR coming that adds loads of features to the query support and I don't have time to now merge it all... this PR should have been reviewed prior to pushing |
This reverts commit 3a910d3.
This reverts commit 3a910d3.
* Revert "Clean up EuiSearchBar docs and reorganize code. (#454)" This partially reverts commit 3a910d3. * Change random.oneOf() to accept an array. * Export Query and Ast services. Import components into examples via the root components module. * Fix typos in docs. * Refactor search bar docs for clearer data flow and render methods. * Import Enzyme utilities from enzyme root module in tests. * Use Component instead of React.Component. * Rename astToES to astToEs. * Fix line-break in CHANGELOG.
2 participants
