Fix checkbox click for checkboxes without a label.#540
Closed
arkwright wants to merge 1 commit intoelastic:masterfrom
Closed
Fix checkbox click for checkboxes without a label.#540arkwright wants to merge 1 commit intoelastic:masterfrom
arkwright wants to merge 1 commit intoelastic:masterfrom
Conversation
384f291 to
605918a
Compare
605918a to
ca5b9e6
Compare
Contributor
|
Technically, #407 didn't break this functionality ;) It was always like this and you are able to add the prop Perhaps we just need to change that prop name, or add an alias to the prop name, that says |
Contributor
|
And we should probably add the same ability to the radio buttons as well. |
Contributor
Author
|
Ah, thanks! I see what's going on now. Upgrading from I'll open another issue for the semantic discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately #407 broke checkboxes without labels — they aren't clickable using a mouse. This fixes that.
Currently the
<input>is rendered offscreen, a<div>is used visually in its place, and a<label>is overlayed on top of the<div>to receive mouse clicks.This PR brings the
<input>back onscreen and visually it usingopacity:0. I also addedcursor:pointerfor consistency with the<label>. I should note that some consider this to be a usability antipattern.