Skip to content

Merge EuiTableRowCell's childClasses into any existing className#709

Merged
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:706-euitablerowcell-classname
May 1, 2018
Merged

Merge EuiTableRowCell's childClasses into any existing className#709
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:706-euitablerowcell-classname

Conversation

@chandlerprall
Copy link
Contributor

Fixes #706 by merging EuiTableRowCells childClasses into any already existing className on the child element, when textOnly === false.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Awesome! LGTM.

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chandlerprall chandlerprall self-assigned this Apr 30, 2018
@cjcenizal
Copy link
Contributor

jenkins test this

@chandlerprall chandlerprall force-pushed the 706-euitablerowcell-classname branch from 65b79b7 to 000999f Compare May 1, 2018 16:01
@chandlerprall chandlerprall merged commit becf30a into elastic:master May 1, 2018
@chandlerprall chandlerprall deleted the 706-euitablerowcell-classname branch May 1, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants