Add dev environment checks#8450
Merged
Merged
Conversation
Contributor
|
@tkajtoch what immediately came to mind is solidarity, might be worth considering! 😄 |
Contributor
|
Maybe I'm missing something but isn't it what yarn does out-of-box when there's an |
| throw new ReportError(MessageName.UNNAMED, message); | ||
| } | ||
|
|
||
| if (process.platform === 'win32') { |
Contributor
There was a problem hiding this comment.
Typical Windows 💚
tkajtoch
force-pushed
the
build/yarn-validate-env
branch
from
36fed90 to
cf61d1a
Compare
tkajtoch
added
the
skip-changelog
|
Preview staging links for this PR:
|
Collaborator
💚 Build Succeeded
History
cc @tkajtoch |
Collaborator
💚 Build SucceededHistorycc @tkajtoch |
Member
Author
|
@weronikaolejniczak Yarn Berry (v2 and above) doesn't check for |
weronikaolejniczak
approved these changes
Apr 16, 2025
Contributor
weronikaolejniczak
left a comment
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Tested, works great! Changes LGTM! 🟢
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #8448
This PR adds Node.js version and OS compatibility checks when running
yarnto ensure equal development environments.QA
gh pr checkout 8450yarnnvm usebeforeyarnnvm install 18 && nvm use 18beforeyarn