Conversation
|
@cchaos Sorry, had a git screwup. Addressed feedback, fixed my copy/pasta and rewrote the mixin to be more specific. Will now also size appropriately against the different panel paddings. |
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
Looks better. I just had one comment about the width stuff.
| .euiPanel.euiPanel--#{$modifier} { | ||
| padding: $amount; | ||
|
|
||
| // Overwrite @hasBetaBadge max-width depending upon padding |
There was a problem hiding this comment.
Should we just make all the width stuff it's own mixin? I can possibly see instances where we may not even want it to have a min-width, so it might be nice to leave it as an option.
There was a problem hiding this comment.
I'm gonna leave this as is for the moment. It's the only usage so making another mixin feels like overkill (for now). If we start using it more we probably should, but for now the @each was there anyway, so it's pretty simple.
2 participants
Replaces #884
Feature request of @nreese.
EuiCardto a more generic mixin, then imported into cards.EuiPanel