EuiComboBox now gives focus to the search input when the user clicks the clear button#918
Merged
cjcenizal merged 1 commit intoelastic:masterfrom Jun 12, 2018
Conversation
cjcenizal
force-pushed
the
combo-box-clear-gives-focus
branch
from
e9e36de to
756a735
Compare
chandlerprall
approved these changes
Jun 11, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Code change LGTM; nice test cases too!
Contributor
|
I have a question about adding the data-test-subj directly to EUI. Can users override these? How should testing be handled when there are more than one combo box on a page? |
Contributor
Author
|
@nreese The user can't override those <EuiComboBox data-test-subj="myComboBox" />
document.querySelector('[data-test-subj="myComboBox"] [data-test-subj="comboBoxToggleListButton"]'); |
…s the clear button, to prevent focus from defaulting to the body. * EuiComboBox is now decorated with data-test-subj selectors for the search input, toggle list button, and clear button. * Updated snapshots.
cjcenizal
force-pushed
the
combo-box-clear-gives-focus
branch
from
756a735 to
2348536
Compare
nreese
approved these changes
Jun 12, 2018
Contributor
nreese
left a comment
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review
tested combo box in EUI help pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents focus from defaulting to the body. It's an accessibility problem if focus suddenly goes to the
bodyelement after clicking a button. The behavior introduced by this PR is also how react-select solves this problem.I also decorated
EuiComboBoxwith data-test-subj selectors for the search input and clear button and tried to make the tests and snapshots a bit clearer regarding what's being tested.