Fixing size of inputs via box-shadow#928
Merged
cchaos merged 2 commits intoelastic:masterfrom Jun 15, 2018
Merged
Conversation
The box-shadow that mimics the input’s border is now `inset`.
Contributor
|
created elastic/kibana#19927 in the kibana repo to track the issue. Thanks for looping me in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The box-shadow that mimics the input’s border is now
inset. This means the40pxheight is actually40pxand the box-shadow ensure it's borders don't spill over the400pxwidth.It's very subtle, hence the zoomed in gif. I also tweaked the second box-shadow slightly to have a better edge to it.
This also touched the
EuiComboBoxListstyles since it was doing extra css to account for the extended border.This originally was noticed as an issue when I saw this:
https://github.com/elastic/kibana/blame/master/src/core_plugins/input_control_vis/public/components/editor/controls_tab.less
So cc'ing @nreese : This will fix the problem you were running into with inputs inside of accordions. When this get's merged into Kibana, can you remove this extra style? It will cause visual issues with the accordion if for some reason it doesn't correctly get the height of
0. See example: