[EuiCodeEditor] Provide selection target for functional tests#939
Merged
ycombinator merged 2 commits intoelastic:masterfrom Jun 21, 2018
Merged
Conversation
With this change, functional tests of code consuming this component can select the code editor element.
ycombinator
changed the title
ycombinator
changed the title
ycombinator
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, functional tests of code consuming this component can select the
EuiCodeEditorelement.You can see an example of this in action if you pull down elastic/kibana#20027 along side this PR and run the functional tests for the Grok Debugger app. More specifically, you can see how the
data-test-subjintroduced in this PR is used for selection here:https://github.com/elastic/kibana/pull/20027/files#diff-4621acc6e44779ce105ee52070f80bafR17