[EuiCodeEditor] Set $blockScrolling = Infinity to prevent console warning#940
Merged
ycombinator merged 3 commits intoelastic:masterfrom Jun 21, 2018
Merged
Conversation
chandlerprall
suggested changes
Jun 21, 2018
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Please add a quick note to the changelog; while the component interface is unchanged this does modify the editor behaviour.
Without this change, this warning is shown in the console: "Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message"
ycombinator
force-pushed
the
code-editor/block-scrolling-warning
branch
from
146188d to
31ebc48
Compare
Contributor
Author
|
@chandlerprall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, this warning would be shown in the console:
Automatically scrolling cursor into view after selection change this will be disabled in the next version set editor.$blockScrolling = Infinity to disable this message