Simplifying form control styles#954
Merged
cchaos merged 4 commits intoelastic:masterfrom Jun 29, 2018
Merged
Conversation
- Made bottom colored border from linear-gradient - Allowing parameters to determine if just the borders should render - Allowing parameters to determine if all state styles should be added - Fixing variable naming schemes
Contributor
Author
|
The only downside is that IE doesn't support transitions on |
snide
approved these changes
Jun 28, 2018
Contributor
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
These are great. So much smoother than before. Peeped the code and it all seems readable to me. Tested in browsers. IE thing isn't that big of a deal.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
The one thing to note is that it no longer has a reverse transition. However, it now matches better with our other animations that also don't have a reverse transition.