Open
Conversation
Collaborator
💚 Build SucceededHistory
cc @tkajtoch |
Collaborator
💚 Build Succeeded
History
cc @tkajtoch |
JasonStoltz
reviewed
Mar 31, 2026
Member
There was a problem hiding this comment.
My overall impression: This is too verbose and text heavy.
A few suggestions:
- Structure this as Dos and Dont's or make it more "rules" based.
- Add examples
- Make text concise -- the intro, for example.
Ex.
Current:
## Layout and scrolling
Enable scrollableInline={true} and tableLayout="auto" to allow horizontal scrolling on overflow to maintain usability across different viewports.
Whenever creating a table, always consider all possible viewport and container sizes, and especially smaller resolutions, even if the application doesn't explicitly support mobile devices. This helps to maintain usability even when push flyouts are open or other container-affecting components are rendered.
...
What is the rule here? Lead with that.
When should we apply this rule, and when should we NOT apply this rule? And if it's a gray area, how do we make that decision?
What does that look like?
Potential option:
## Enable horizontal scrolling
**Always design tables for the narrowest container they may appear in** -- including
states where push flyouts, sidebars, or other elements reduce available width.Enable horizontal scrolling
Set `scrollableInline={true}` and `tableLayout="auto"` so the table scrolls
horizontally on overflow rather than compressing columns into illegibility.
:::tip
Test your table at ~600 px width or with a push flyout open.
If columns become unreadable, horizontal scrolling should take over.
:::
- Can we tie this together with Kibana utils? Something we do this elsewhere:
:::note Kibana engineers
Kibana provides presets which do {xyz}. You can read more here {link to presets}
We enforce these guidelines in Kibana with lint rules, which are here {link to lint rules}
:::
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Resolves #9527
This PR adds table layout guidelines as part of the tables sweep initiative.
API Changes
N/A; Documentation only
Screenshots
Impact Assessment
💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).🔧 Hard to integrate — If integration is complex, stage commits in Kibana/Cloud UI branches for cherry-picking and link to them below.Impact level: 🟢 None
Release Readiness
Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
Checklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaTests: Added/updated Jest, Cypress, and VRTChangelog: Added changelog entryBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist