Skip to content

[Website] Fix EuiFlyout JSDoc docs link#9563

Merged
weronikaolejniczak merged 1 commit intoelastic:mainfrom
weronikaolejniczak:fix/docs-link
Apr 7, 2026
Merged

[Website] Fix EuiFlyout JSDoc docs link#9563
weronikaolejniczak merged 1 commit intoelastic:mainfrom
weronikaolejniczak:fix/docs-link

Conversation

@weronikaolejniczak
Copy link
Copy Markdown
Contributor

The "EuiFlyout session management" link doesn't work. It redirects to docs/components/containers/flyout/session-management that doesn't exist. Instead, _session_management.mdx is a partial within the same page and can be navigated to using docs/components/containers/flyout/#flyout-session-management anchor.

The fix is to use that anchor in the JSDoc in EuiFlyout. Simple.

Raised internally.

Screen.Recording.2026-04-05.at.11.06.21.PM.mov

QA

  • Verify the link in staging redirects to the proper heading

Copilot AI review requested due to automatic review settings April 7, 2026 09:17
@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner April 7, 2026 09:17
@weronikaolejniczak weronikaolejniczak self-assigned this Apr 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the EuiFlyout TypeScript/JSDoc to point “session management” documentation links to the correct on-page anchor in the EUI docs site, fixing a previously broken redirect.

Changes:

  • Replace the outdated /flyout/session-management URL with the /#flyout-session-management anchor link in EuiFlyout JSDoc.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@weronikaolejniczak weronikaolejniczak added the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Apr 7, 2026
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @weronikaolejniczak

Copy link
Copy Markdown
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Thanks for the quick fix! The link works as expected now.

@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) April 7, 2026 09:55
@weronikaolejniczak weronikaolejniczak merged commit 2b176da into elastic:main Apr 7, 2026
11 of 12 checks passed
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @weronikaolejniczak

weronikaolejniczak added a commit to weronikaolejniczak/eui that referenced this pull request Apr 7, 2026
weronikaolejniczak added a commit to weronikaolejniczak/eui that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants