Skip to content

[EuiCheckableCard] Fix checked border#9589

Merged
mgadewoll merged 4 commits intoelastic:mainfrom
mgadewoll:checkablecard/fix-checked-border
Apr 13, 2026
Merged

[EuiCheckableCard] Fix checked border#9589
mgadewoll merged 4 commits intoelastic:mainfrom
mgadewoll:checkablecard/fix-checked-border

Conversation

@mgadewoll
Copy link
Copy Markdown
Contributor

@mgadewoll mgadewoll commented Apr 13, 2026

Summary

This PR fixes a visual issue on EuiCheckableCard to ensure the card receives a visible checked state by applying a blue border.

API Changes

⚪ No API changes

Screenshots

Before After
Screenshot 2026-04-13 at 09 12 45 Screenshot 2026-04-13 at 09 12 49

Impact Assessment

Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If changes require substantial updates to Kibana, please stage the changes and link them here.

Impact level: 🟢 None

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

💻 EuiCheckableCard storybook

  • verify that a checked EuiCheckableCard has a blue border

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

@mgadewoll mgadewoll self-assigned this Apr 13, 2026
@mgadewoll mgadewoll changed the title [EUiCheckableCard] Fix checked border [EuiCheckableCard] Fix checked border Apr 13, 2026
@mgadewoll mgadewoll force-pushed the checkablecard/fix-checked-border branch from 6b47f67 to 8ab82be Compare April 13, 2026 08:01
@mgadewoll mgadewoll marked this pull request as ready for review April 13, 2026 08:41
@mgadewoll mgadewoll requested a review from a team as a code owner April 13, 2026 08:41
Copilot AI review requested due to automatic review settings April 13, 2026 08:41
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ good we added a VRT-only story. Thanks, Lene!

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes EuiCheckableCard’s checked visual state so it shows a visible “checked” border by applying the primary (blue) border color to the same border implementation used by EuiPanel/EuiSplitPanel (pseudo-element border), and adds a dedicated VRT story + reference screenshots.

Changes:

  • Update EuiCheckableCard styles to apply/animate checked border color via the panel border pseudo-element (::after)
  • Add a Checked Storybook story tagged for VRT coverage
  • Add an upcoming changelog entry and Loki reference images for the new VRT

Reviewed changes

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/eui/src/components/card/checkable_card/checkable_card.styles.ts Moves checked border color + transition to ::after to match EuiPanel’s border rendering
packages/eui/src/components/card/checkable_card/checkable_card.stories.tsx Adds Checked story for VRT-only coverage
packages/eui/changelogs/upcoming/9589.md Documents the bug fix in the upcoming changelog
packages/eui/.loki/reference/chrome_mobile_Display_EuiCheckableCard_Checked.png Updates/adds mobile VRT reference image
packages/eui/.loki/reference/chrome_desktop_Display_EuiCheckableCard_Checked.png Updates/adds desktop VRT reference image

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/eui/src/components/card/checkable_card/checkable_card.styles.ts Outdated
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

@mgadewoll mgadewoll merged commit 5766252 into elastic:main Apr 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants