[EuiCheckableCard] Fix checked border#9589
Merged
mgadewoll merged 4 commits intoelastic:mainfrom Apr 13, 2026
Merged
Conversation
6b47f67 to
8ab82be
Compare
weronikaolejniczak
approved these changes
Apr 13, 2026
Contributor
weronikaolejniczak
left a comment
There was a problem hiding this comment.
LGTM ✅ good we added a VRT-only story. Thanks, Lene!
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes EuiCheckableCard’s checked visual state so it shows a visible “checked” border by applying the primary (blue) border color to the same border implementation used by EuiPanel/EuiSplitPanel (pseudo-element border), and adds a dedicated VRT story + reference screenshots.
Changes:
- Update
EuiCheckableCardstyles to apply/animate checked border color via the panel border pseudo-element (::after) - Add a
CheckedStorybook story tagged for VRT coverage - Add an upcoming changelog entry and Loki reference images for the new VRT
Reviewed changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/eui/src/components/card/checkable_card/checkable_card.styles.ts | Moves checked border color + transition to ::after to match EuiPanel’s border rendering |
| packages/eui/src/components/card/checkable_card/checkable_card.stories.tsx | Adds Checked story for VRT-only coverage |
| packages/eui/changelogs/upcoming/9589.md | Documents the bug fix in the upcoming changelog |
| packages/eui/.loki/reference/chrome_mobile_Display_EuiCheckableCard_Checked.png | Updates/adds mobile VRT reference image |
| packages/eui/.loki/reference/chrome_desktop_Display_EuiCheckableCard_Checked.png | Updates/adds desktop VRT reference image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a visual issue on
EuiCheckableCardto ensure the card receives a visible checked state by applying a blue border.API Changes
⚪ No API changes
Screenshots
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None
Release Readiness
Documentation: {link to docs page(s)}Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
💻 EuiCheckableCard storybook
EuiCheckableCardhas a blue borderChecklist before marking Ready for Review
QA: Tested in CodeSandbox and [Kibana](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/testing-in-kibana.md)QA: Tested docs changesBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist