[EuiMarkdownEditor][A11y] Fix invalid nested interactive elements#9625
Merged
mgadewoll merged 7 commits intoelastic:mainfrom May 5, 2026
Merged
Conversation
- prevent invalid nested interactive elements
Contributor
Author
|
buildkite test this |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an accessibility issue in EuiMarkdownEditor by removing the drop zone wrapper’s misleading role="button", which was creating an invalid nested interactive-element structure around the textarea.
Changes:
- Removes the default drop zone
roleinmarkdown_editor_drop_zone.tsx - Adds a Storybook drop-zone scenario for manual QA
- Updates Jest snapshots and adds a changelog entry for the accessibility fix
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/eui/src/components/markdown_editor/markdown_editor.stories.tsx |
Adds a new DropZone story with a stateful wrapper for manual drag-and-drop testing. |
packages/eui/src/components/markdown_editor/markdown_editor_drop_zone.tsx |
Removes the drop zone wrapper’s role="button" assignment. |
packages/eui/src/components/markdown_editor/__snapshots__/markdown_editor.test.tsx.snap |
Updates rendered snapshots to reflect the removed role attribute. |
packages/eui/changelogs/upcoming/9625.md |
Documents the accessibility fix in the upcoming changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caused by: elastic/kibana#263605
This PR updates
EuiMarkdownEditorby removing the addedrole="button"on the drop zone wrapper element.This would result in invalid nested interactive elements as the button would nest the textarea.
The change removes the
rolecompletely, considering that the drop zone doesn't actually support keyboard interaction as is (it's also disabled vianoKeyboardin the drop zone settings). The drop zone basically only works for mouse interaction while we're already making use of a standalone way via a button in the footer to add files instead.API Changes
⚪ No API changes
Screenshots
Screen.Recording.2026-04-30.at.14.06.10.mov
Screen.Recording.2026-04-30.at.14.06.42.mov
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 Low
The removes
rolemight require snapshot updates.Release Readiness
Documentation: {link to docs page(s)}Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
💻 EuiMarkdownEditor storybook
Checklist before marking Ready for Review
QA: Tested in CodeSandbox and [Kibana](https://github.com/elastic/eui/blob/main/wiki/contributing-to-eui/testing/testing-in-kibana.md)QA: Tested docs changesBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist