[ESLint][EuiToolTip] Add ESLint rules for tooltip best practices#9635
Open
weronikaolejniczak wants to merge 3 commits intoelastic:mainfrom
Open
[ESLint][EuiToolTip] Add ESLint rules for tooltip best practices#9635weronikaolejniczak wants to merge 3 commits intoelastic:mainfrom
weronikaolejniczak wants to merge 3 commits intoelastic:mainfrom
Conversation
5f88551 to
0ee7d72
Compare
0ee7d72 to
2803da0
Compare
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tooltip_button_icon_wrap- we want allEuiButtonIconwrapped withEuiToolTiptooltip_no_interactive_content- it's against WCAG specification for tooltip content to be interactivewarn,EuiButtonIconwrap has an auto-fix, "no interactive content" one doesn'tEuiButtonIconwithEuiToolTipAPI Changes
N/A
Screenshots
N/A
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None
Release Readiness
Documentation: {link to docs page(s)}Figma: {link to Figma or issue}Migration guide: {steps or link, for breaking/visual changes or deprecations}Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}QA instructions for reviewer
yarn workspace @elastic/eslint-plugin-eui testChecklist before marking Ready for Review
QA: Tested light/dark modes, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen readerQA: Tested in CodeSandbox and KibanaQA: Tested docs changesCypress, and VRTBreaking changes: Addedbreaking changelabel (if applicable)Reviewer checklist