[EuiDataGrid] Stabilize column header layout for actions control#9637
Draft
flash1293 wants to merge 1 commit intoelastic:mainfrom
Draft
[EuiDataGrid] Stabilize column header layout for actions control#9637flash1293 wants to merge 1 commit intoelastic:mainfrom
flash1293 wants to merge 1 commit intoelastic:mainfrom
Conversation
Introduce headerColumnActionsVisibility (hover | always) and headerColumnActionsDisplay (inline | overlay) on EuiDataGridStyle so consumers can avoid header height and flex layout shift when the column actions control appears. Refs elastic#9104 Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
💚 Build Succeeded |
Collaborator
💚 Build Succeeded
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two optional fields on
EuiDataGridStyle(via thegridStyleprop onEuiDataGrid) so apps can avoid the column header height / flex layout shift when the per-column actions (⋮) control appears on hover:headerColumnActionsVisibility:'hover'(default) or'always'— keeps the actions affordance visible so wrapped header text does not reflow on hover.headerColumnActionsDisplay:'inline'(default) or'overlay'— positions the actions anchor absolutely at the inline end of the header cell so it does not participate in flex layout; combined with a steady header gap in overlay mode, hover no longer toggles spacing.Defaults are wired through
startingStylesso existing grids behave unchanged.Related
Fixes #9104
Testing
yarn test-unit --changedSince main(pre-push)Made with Cursor