[ESLint][EuiCallOut] Add ESLint rules for EuiCallOut content best practices#9684
Draft
mgadewoll wants to merge 12 commits into
Draft
Conversation
- additionally connects the new notification icons to the compile-icon script
8ba0548 to
d441167
Compare
Collaborator
💚 Build SucceededHistory
cc @mgadewoll |
Collaborator
💚 Build Succeeded
History
cc @mgadewoll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
This PR merges into a feature branch.
And it depends on changes from #9642 and requires rebase once that PR is merged.
This PR adds 2 new ESLint rules:
@elastic/eui/callout-require-title@elastic/eui/callout-prefer-props-for-contentBoth rules are set to
warn. They are meant to help migrate from the legacy component prop usages that passes content viachildrentowards the new API using dedicatedtextandactionPropsprops which were introduced in #9642.Rules
callout-title-requiredcallout-prefer-props-for-contentAPI Changes
⚪ No API changes
Screenshots
Impact Assessment
Note: Most PRs should be tested in Kibana to help gauge their Impact before merging.
Impact level: 🟢 None / 🟢 Low / 🟡 Moderate / 🔴 High
Release Readiness
QA instructions for reviewer
Checklist before marking Ready for Review
breaking changelabel (if applicable)Reviewer checklist