Link XYChart components to experimental directory#975
Conversation
cchaos
left a comment
cchaos
left a comment
There was a problem hiding this comment.
LGTM, all the demos still load properly. Just one nit-picky comment and don't forget to add a changelog entry.
| export * from './components'; | ||
| export * from './services'; | ||
| export * from './utils'; | ||
| export * from './experimental'; |
There was a problem hiding this comment.
Can you re-order this list to be alphabetical order?
| .replace(/(from )'(..\/)+src\/components(\/?';)/, `from '@elastic/eui';`) | ||
| .replace(/(from )'(..\/)+src\/services(\/?';)/, `from '@elastic/eui/services';`); | ||
| .replace(/(from )'(..\/)+src\/services(\/?';)/, `from '@elastic/eui/services';`) | ||
| .replace(/(from )'(..\/)+src\/experimental(\/?';)/, `from '@elastic/eui/experimental';`); |
There was a problem hiding this comment.
@cjcenizal could you check this? #976 because I'm not really sure if it's better to have /lib/experimental or /experimental
There was a problem hiding this comment.
and maybe it's related to the build
There was a problem hiding this comment.
I think the correct path would be eui/lib/experimental because otherwise someone who copy-pastes the code would have a broken import, right?
There was a problem hiding this comment.
I think so, also for services needs to be the same. I will change it and than merge it.
There was a problem hiding this comment.
CJ is correct, and the existing @elastic/eui/services is wrong and should be @elastic/eui/lib/services
4 participants
This PR comes after a discussion with @cchaos @snide @mattapperson about specifying a bit more that these is a beta/experimental version of the XYChart and that APIs and features can change easily in the feature.
This PR changed the way to import beta XYChart components, forcing developers to import these components from
/experimentalpath like:The components are not moved from the
/componentsfolder, but the exporting module reside in the/src/experimental/index.jsfile.The PR also updated the function for rendering example code to correctly handle the experimental components.