Skip to content

Use dev-tools/go.mod for tool tracking#4694

Merged
michel-laterman merged 1 commit intoelastic:mainfrom
michel-laterman:dev-tools
Mar 28, 2025
Merged

Use dev-tools/go.mod for tool tracking#4694
michel-laterman merged 1 commit intoelastic:mainfrom
michel-laterman:dev-tools

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

What is the problem this PR solves?

Use go 1.24's tool directive for (most) development tools.

How does this PR solve the problem?

Use a go.mod file in the dev-tools dir to track tools used by fleet-server; golangci-lint is the single exception.
The golangci-lint version is now only specified in the .github/workflow/golangci-lint.yml file.

@michel-laterman michel-laterman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team tech debt labels Mar 26, 2025
@michel-laterman michel-laterman requested a review from a team as a code owner March 26, 2025 17:53
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2025

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@elastic-sonarqube
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised to see that the top-level go.mod didn't have any changes. Shouldn't those dependencies be removed from that file? That would also result in a smaller NOTICE.txt which I also do not see here.

@pkoutsovasilis
Copy link
Copy Markdown
Contributor

Surprised to see that the top-level go.mod didn't have any changes. Shouldn't those dependencies be removed from that file? That would also result in a smaller NOTICE.txt which I also do not see here.

To be honest initially I was expecting the same. Then taking a closer look I saw that @michel-laterman just moved the "tools" inside the dev-tools/go.mod and these weren't included to begin with in the main module go.mod. These were just installed through the Makefile but now they are automatically installed by the go toolchain, I like it I think. wdyt? 🙂

@michel-laterman
Copy link
Copy Markdown
Contributor Author

The tools weren't a part of the top level go.mod file; i have another branch where I tried doing that, and it adds a bunch of dependencies and licenses

@blakerouse
Copy link
Copy Markdown
Contributor

Thanks @michel-laterman and @pkoutsovasilis for the explanation.

@michel-laterman michel-laterman merged commit befcf5d into elastic:main Mar 28, 2025
10 checks passed
@michel-laterman michel-laterman deleted the dev-tools branch March 28, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team tech debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants