Use dev-tools/go.mod for tool tracking#4694
Conversation
|
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
|
blakerouse
left a comment
There was a problem hiding this comment.
Surprised to see that the top-level go.mod didn't have any changes. Shouldn't those dependencies be removed from that file? That would also result in a smaller NOTICE.txt which I also do not see here.
To be honest initially I was expecting the same. Then taking a closer look I saw that @michel-laterman just moved the "tools" inside the dev-tools/go.mod and these weren't included to begin with in the main module go.mod. These were just installed through the Makefile but now they are automatically installed by the go toolchain, I like it I think. wdyt? 🙂 |
|
The tools weren't a part of the top level go.mod file; i have another branch where I tried doing that, and it adds a bunch of dependencies and licenses |
|
Thanks @michel-laterman and @pkoutsovasilis for the explanation. |





What is the problem this PR solves?
Use go 1.24's tool directive for (most) development tools.
How does this PR solve the problem?
Use a go.mod file in the dev-tools dir to track tools used by fleet-server; golangci-lint is the single exception.
The golangci-lint version is now only specified in the
.github/workflow/golangci-lint.ymlfile.