Skip to content

Removed quotes from changelog file#4747

Merged
ebeahan merged 2 commits into
mainfrom
rm_quotes_from_filename
Mar 31, 2025
Merged

Removed quotes from changelog file#4747
ebeahan merged 2 commits into
mainfrom
rm_quotes_from_filename

Conversation

@pazone
Copy link
Copy Markdown

@pazone pazone commented Mar 31, 2025

What is the problem this PR solves?

The quotes in the file prevented us from cloning this repository on Windows
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

The quotes were removed from the filename
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@pazone pazone added the enhancement New feature or request label Mar 31, 2025
@pazone pazone requested review from AndersonQ and oakrizan March 31, 2025 09:31
@pazone pazone requested a review from a team as a code owner March 31, 2025 09:31
@pazone pazone requested a review from kaanyalti March 31, 2025 09:31
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 31, 2025

This pull request does not have a backport label. Could you fix it @pazone? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

AndersonQ
AndersonQ previously approved these changes Mar 31, 2025
@AndersonQ
Copy link
Copy Markdown
Member

@pazone don't you wanna take the opportunity and remove the . and : from the name as well?

@pazone
Copy link
Copy Markdown
Author

pazone commented Mar 31, 2025

@AndersonQ Also removed . and :

@ebeahan ebeahan merged commit c6350de into main Mar 31, 2025
@ebeahan ebeahan deleted the rm_quotes_from_filename branch March 31, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants