feat: Add queue size multiplier config to BulkIndexer #1029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
👋 Hi @Anaethelion! |
Contributor
Author
|
Hi! @marciw @Anaethelion @szabosteve Bumping the previous message. A review would be greatly appreciated, thanks! |
Contributor
|
Hi @Stephanie0829, apologies for the late response, we'll check this over soon and get back to you ASAP. |
Contributor
Author
|
@MattDevy Hi! Sorry to bother, are there any updates? |
MattDevy
changed the title
Contributor
@Stephanie0829 no worries at all. I've added some unit tests to cover the new functionality. Thank you for your contribution, this looks great! |
MattDevy
approved these changes
Nov 20, 2025
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- Co-authored-by: Matt Devy <matt.devy@elastic.co> (cherry picked from commit c2f52b5)
Closed
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- Co-authored-by: Matt Devy <matt.devy@elastic.co> (cherry picked from commit c2f52b5)
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- Co-authored-by: Matt Devy <matt.devy@elastic.co> (cherry picked from commit c2f52b5)
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- (cherry picked from commit c2f52b5) Co-authored-by: Stephanie Wei <72533858+Stephanie0829@users.noreply.github.com>
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- (cherry picked from commit c2f52b5) Co-authored-by: Stephanie Wei <72533858+Stephanie0829@users.noreply.github.com>
MattDevy
added a commit
that referenced
this pull request
Nov 20, 2025
* Add queue size multiplier config to BulkIndexer * test: add unit tests for QueueSizeMultiplier BulkIndexerConfig value --------- (cherry picked from commit c2f52b5) Co-authored-by: Stephanie Wei <72533858+Stephanie0829@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses feature request in #1027.
This pull request exposes a worker queue size multiplier config
QueueSizeMultiplier, which allows user to more flexibly configure their buffer size. This is especially helpful for systems with bursty traffic.The default value is set to 1, which maintains the existing behavior as the default.
Tested by locally confirming that setting new config will increase queue capacity.