Skip to content

Conversation

@MattDevy
Copy link
Contributor

@MattDevy MattDevy commented Nov 24, 2025

  • Adds Close method to BaseClient
  • Fixes Bulk Indexer Close behaviour
  • Documents new Close method

Relates to: #875

@MattDevy MattDevy requested a review from Anaethelion November 24, 2025 11:53
@prodsecmachine
Copy link

prodsecmachine commented Nov 24, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

@MattDevy MattDevy marked this pull request as draft November 24, 2025 12:28
@MattDevy MattDevy marked this pull request as ready for review November 24, 2025 14:40
@MattDevy MattDevy changed the title feat: adds Close method to BaseClient feat: add Close method to BaseClient Nov 25, 2025
@MattDevy MattDevy merged commit 9d9d191 into main Nov 26, 2025
18 checks passed
@MattDevy MattDevy deleted the feat/close branch November 26, 2025 13:06
@elastic-vault-github-plugin-prod

The backport to 8.19 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.19 8.19
# Navigate to the new working tree
cd .worktrees/backport-8.19
# Create a new branch
git switch --create backport-1056-to-8.19
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9d9d1911ef368906e09dd872ae641620eb9d3d53
# Push it to GitHub
git push --set-upstream origin backport-1056-to-8.19
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.19

Then, create a pull request where the base branch is 8.19 and the compare/head branch is backport-1056-to-8.19.

elastic-vault-github-plugin-prod bot pushed a commit that referenced this pull request Nov 26, 2025
elastic-vault-github-plugin-prod bot pushed a commit that referenced this pull request Nov 26, 2025
MattDevy added a commit that referenced this pull request Nov 26, 2025
MattDevy added a commit that referenced this pull request Nov 26, 2025
MattDevy added a commit that referenced this pull request Nov 26, 2025
(cherry picked from commit 9d9d191)

Co-authored-by: Matt Devy <32791943+MattDevy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants