[Backport 9.1] fix: Notify items if an error occurs in bulk indexer #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
* notify items if an error occurs in bulk indexer * fix message error on line 577 * test: OnFailure is called per item * refactor: use a method to handle errors * makes code DRYer * fixes bug where `res.IsError()` resulted in BulkIndexerItem.OnError receiving a nil `err` --------- Co-authored-by: Matt Devy <matt.devy@elastic.co> (cherry picked from commit 6ea4a8a)
MattDevy
force-pushed
the
backport-615-to-9.1
branch
from
489eb55 to
3ab2556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 6ea4a8a from #615.
BEGIN_COMMIT_OVERRIDE
fix: Notify items if an error occurs in bulk indexer (#615) (#1058)
END_COMMIT_OVERRIDE