Skip to content

[Licence Header] Use try-with-resources for Files.lines() to prevent file handle leaks #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lloydmeta wants to merge 1 commit into from
Closed

[Licence Header] Use try-with-resources for Files.lines() to prevent file handle leaks #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ns/license-headers/src/main/java/co/elastic/gradle/license_headers/LicenseCheckUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.stream.Stream;

public class LicenseCheckUtils {

Expand All @@ -36,8 +37,8 @@ public static Map<Path, ViolationReason> nonCompliantFilesWithReason(Path projec

for (File file : files) {
final String[] fileHeader;
try {
fileHeader = Files.lines(file.toPath()).limit(expectedHeader.length).toArray(String[]::new);
try (Stream<String> lines = Files.lines(file.toPath())) {
fileHeader = lines.limit(expectedHeader.length).toArray(String[]::new);
} catch (IOException| UncheckedIOException e) {
throw new GradleException("Failed to read " + projectDir.relativize(file.toPath()), e);
}
Expand Down