Update Fleet Server install docs to match UI #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilfoyle
commented
May 16, 2023
Comment on lines
+196
to
+200
| * If you've configured a non-default port for {fleet-server} in the | ||
| {fleet-server} integration, you need to include the `--fleet-server-host` and | ||
| `--fleet-server-port` options in the `elastic-agent install` command. Refer to the | ||
| {fleet-guide}/elastic-agent-cmd-options.html#elastic-agent-install-command[install command documentation] | ||
| for details. |
Contributor
Author
There was a problem hiding this comment.
@lucabelluccini, here's the note that I added to address your comment in the parent issue. Please let me know if I didn't get it right. :-)
karenzone
approved these changes
May 18, 2023
Contributor
karenzone
left a comment
karenzone
left a comment
There was a problem hiding this comment.
Left comments for consideration. Otherwise, LGTM
docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc
Outdated
Show resolved
Hide resolved
docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
kilfoyle
added a commit
to kilfoyle/ingest-docs
that referenced
this pull request
May 23, 2023
* Update Fleet Server on-prem setup docs * Remove tagged regions since Cloud and on-prem are too different * touchup * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 681bf27)
kilfoyle
added a commit
to kilfoyle/ingest-docs
that referenced
this pull request
May 23, 2023
* Update Fleet Server on-prem setup docs * Remove tagged regions since Cloud and on-prem are too different * touchup * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 681bf27)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kilfoyle
added a commit
that referenced
this pull request
May 23, 2023
* Update Fleet Server on-prem setup docs * Remove tagged regions since Cloud and on-prem are too different * touchup * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 681bf27)
kilfoyle
added a commit
that referenced
this pull request
May 23, 2023
* Update Fleet Server on-prem setup docs * Remove tagged regions since Cloud and on-prem are too different * touchup * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> * Update docs/en/ingest-management/fleet/add-fleet-server-on-prem.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 681bf27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes up these pages:
Changes include:
--fleet-server-hostand--fleet-server-port, per this request from Luca.For now, I've commented out some content rather than removing it, just in case at some point we need to trace back on the history of what was changed.
Closes: #99