Skip to content

Conversation

@belimawr
Copy link
Contributor

@belimawr belimawr commented Apr 16, 2025

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Verify when the delete feature will be released
  • Wait for the compatible Elastic-Agent/Filebeat to be released

How to test this PR locally

  1. Create a log file > 1kb (e.g.: /tmp/flog.log)
  2. Add the Custom Filestream integration configured to ingest the file you created and enable:
    1. "Delete files after they have been ingested"
    2. "Close Reader EOF"
  3. Set "Grace period for deleting files" to 1m
  4. Deploy and start the Elastic-Agent
  5. Wait for the file to be fully read and removed.
  6. Assert the log file has been removed

You can watch Filestream's logs by running:

elastic-agent logs -f -C 'filestream-default'| jq '{"ts": ."@timestamp", "lvl": ."log.level", "logger": ."log.logger", "m": .message}' -c

You will see the logs related to the delete feature:

{"ts":"2025-11-17T22:15:43.729Z","lvl":"info","logger":"input.filestream","m":"all events from '/tmp/flog.log' have been published, waiting for 1m0s grace period"}
{"ts":"2025-11-17T22:16:43.733Z","lvl":"info","logger":"input.filestream","m":"'/tmp/flog.log' removed"}

Related issues

Screenshots

Screenshot_2025-11-17_17-11-09

@belimawr belimawr added the enhancement New feature or request label Apr 16, 2025
@belimawr belimawr self-assigned this Apr 16, 2025
@elastic-sonarqube
Copy link

@andrewkroh andrewkroh added the Integration:filestream Custom Logs (Filestream) label Apr 16, 2025
@botelastic
Copy link

botelastic bot commented May 16, 2025

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 16, 2025
@botelastic
Copy link

botelastic bot commented Jun 15, 2025

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Jun 15, 2025
@sinzzor
Copy link

sinzzor commented Nov 13, 2025

Hi! Any chance this could get some love? Would be lovely to have this GA feature in the integration as well.

@belimawr
Copy link
Contributor Author

Hi! Any chance this could get some love? Would be lovely to have this GA feature in the integration as well.

I'm looking into that @sinzzor.

@belimawr belimawr reopened this Nov 17, 2025
@botelastic botelastic bot removed the Stalled label Nov 17, 2025
@belimawr belimawr marked this pull request as ready for review November 17, 2025 22:18
@belimawr belimawr requested a review from a team as a code owner November 17, 2025 22:18
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @belimawr

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane] label Nov 18, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@belimawr belimawr merged commit 843a138 into elastic:main Nov 24, 2025
7 checks passed
@elastic-vault-github-plugin-prod

Package filestream - 2.2.0 containing this change is available at https://epr.elastic.co/package/filestream/2.2.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:filestream Custom Logs (Filestream) Team:Elastic-Agent-Data-Plane Agent Data Plane team [elastic/elastic-agent-data-plane]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants