[Logstash integration] Add current and peak connections metrics of elastic-agent input plugin. #15148
Conversation
| "counter_map": has(body.pipelines[pipeline_name].vertices) ? | ||
| body.pipelines[pipeline_name].vertices.map(vertex, has(vertex.long_counters), vertex.long_counters.map(counter, { | ||
| body.pipelines[pipeline_name].vertices.map(vertex, has(vertex.long_counters) || has(vertex.double_gauges), | ||
| ((has(vertex.long_counters) ? vertex.long_counters : []) + (has(vertex.double_gauges) ? vertex.double_gauges : [])).map(counter, { |
There was a problem hiding this comment.
review note: peak and current connections are gauge metrics and comes through _node/stats?vertices=true API response -> vertices -> double_gauges
See: elastic/logstash#18082
|
How would |
andrewkroh
added
Integration:logstash
Yup, they together also fine I think, It becomes looks like this: |
robbavey
left a comment
robbavey
left a comment
There was a problem hiding this comment.
Minor nit on naming, and a question on changelog/release strategy
packages/logstash/kibana/dashboard/logstash-23d2c717-0fd1-4cb1-8d10-69c2fe669a63.json
Outdated
Show resolved
Hide resolved
packages/logstash/changelog.yml
Outdated
| # newer versions go on top | ||
| - version: "2.8.0" | ||
| changes: | ||
| - description: Adds elastic_agent or beats input plugin current and peak connections dashboard. |
There was a problem hiding this comment.
Given that this won't work until elastic/logstash#18082 and friends are in released versions of Logstash, should we a) hold off on publishing until a compatible version(s) of Logstash is available (or at least imminent - we can release note this in the appropriate versions of Logstash), and b) note which versions of Logstash are required to enable this plugin.
There was a problem hiding this comment.
Yup, on Sept. 16, I will add a note here about LS versions: 8.18.7, 8.19.4, 9.0.7, 9.1.4
🚀 Benchmarks reportTo see the full report comment with |
…gin and visualizes on dashboard.
mashhurs
force-pushed
the
support-gauge-metrics-in-ls-integration
branch
from
f6610b3 to
7bd74d9
Compare
💚 Build Succeeded
History
cc @mashhurs |
|
…astic-agent input plugin. (elastic#15148) * Saves current and peak connections metrics of elastic-agent input plugin and visualizes on dashboard. * Update the type migration version which was snapshot before. * Unify current and peak connections graphs into single view. * Rename y-axis title. * Rename the dashboard title and panel. * Specify Logstash versions which expose these metrics.
4 participants
Proposed commit message
Save current and peak connection metrics of the Logstash elastic_agent/beats input plugin and visualize its metrics on dashboard.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots