-
Notifications
You must be signed in to change notification settings - Fork 519
[azure logs] Add processor version options to Raw Events integration (v1) #15900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
packages/azure/data_stream/activitylogs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
1bc4092 to
d5e9f6a
Compare
muthu-mps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmoog - changelog entry is missing, change looks good to me otherwise!
kaiyan-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me! Lets add a changelog and it's good to go!
Adding changelog and running a final test before merging. |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
@elastic/security-service-integrations, could you take a look at this PR when you have time? |
b4ffb98 to
27ab064
Compare
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link to the background in the commit message would be helpful.
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
# Conflicts: # packages/azure/changelog.yml # packages/azure/manifest.yml
648b982 to
b494949
Compare
efd6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is waiting for obs-ds-hosted-services, but LGTM.
| {{#if processor_update_interval}} | ||
| processor_update_interval: {{processor_update_interval}} | ||
| {{/if}} | ||
| {{#if processor_start_position}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add sth like if processor_version}==v2 then processor_start_position?
Same also for below fields that are only realted to v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a couple of checklist items for this in the next issue #15703, so I can do the same across all the integrations using this input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the built-in helper #if only supports checking if a value is empty to skip rendering a block:
From https://handlebarsjs.com/guide/builtin-helpers.html#if:
You can use the if helper to conditionally render a block. If its argument returns false, undefined, null, "", 0, or [], Handlebars will not render the block.
This problem should auto-resolve soon as we are switching to processor v2 as default and dropping v1 after that.
Updated all the occurrences of the following config options: - `processor_version` - `processor_start_position`
zmoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched to type: select UI element in Azure Logs and Custom Azure Logs integrations.
The built-in helper #if doesn't seem to support expressions though.
| {{#if processor_update_interval}} | ||
| processor_update_interval: {{processor_update_interval}} | ||
| {{/if}} | ||
| {{#if processor_start_position}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also added a couple of checklist items for this in the next issue #15703, so I can do the same across all the integrations using this input.
| {{#if processor_update_interval}} | ||
| processor_update_interval: {{processor_update_interval}} | ||
| {{/if}} | ||
| {{#if processor_start_position}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the built-in helper #if only supports checking if a value is empty to skip rendering a block:
From https://handlebarsjs.com/guide/builtin-helpers.html#if:
You can use the if helper to conditionally render a block. If its argument returns false, undefined, null, "", 0, or [], Handlebars will not render the block.
This problem should auto-resolve soon as we are switching to processor v2 as default and dropping v1 after that.
💚 Build Succeeded
History
cc @zmoog |
|
Package azure - 1.30.0 containing this change is available at https://epr.elastic.co/package/azure/1.30.0/ |
|
Package azure_logs - 0.4.2 containing this change is available at https://epr.elastic.co/package/azure_logs/0.4.2/ |
…(v1) (elastic#15900) Add the processor version option to the Raw Events integration v1. With these new options, users can switch from processor v1 (current default) to the processor v2. This change anticipate the switch to v2 as default processor.
Proposed commit message
Add the processor version option to the Raw Events integration v1. With these new options, users can switch from processor v1 (current default) to the processor v2.
This change anticipate the switch to v2 as default processor, see #15703 for context and more details.
Checklist
changelog.ymlfile.I have verified that any added dashboard complies with Kibana's Dashboard good practicesHow to test this PR locally
v2Screenshots