Skip to content

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Nov 7, 2025

Proposed commit message

Add the processor version option to the Raw Events integration v1. With these new options, users can switch from processor v1 (current default) to the processor v2.

This change anticipate the switch to v2 as default processor, see #15703 for context and more details.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Install the Raw Events integration (v1)
  • Open "Advanced settings", and set Processor version to v2

Screenshots

CleanShot 2025-11-07 at 12 54 05@2x

@zmoog zmoog self-assigned this Nov 7, 2025
@zmoog zmoog added Integration:azure Azure Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] labels Nov 7, 2025
@zmoog zmoog marked this pull request as ready for review November 7, 2025 12:09
@zmoog zmoog requested review from a team as code owners November 7, 2025 12:09
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Nov 7, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] label Nov 7, 2025
@zmoog zmoog force-pushed the integrations-raw-events-v2 branch 2 times, most recently from 1bc4092 to d5e9f6a Compare November 7, 2025 14:24
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zmoog - changelog entry is missing, change looks good to me otherwise!

Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me! Lets add a changelog and it's good to go!

@zmoog zmoog requested a review from a team as a code owner November 13, 2025 21:12
@zmoog
Copy link
Contributor Author

zmoog commented Nov 13, 2025

It looks good to me! Lets add a changelog and it's good to go!

Adding changelog and running a final test before merging.

@zmoog zmoog added the Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] label Nov 13, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@zmoog
Copy link
Contributor Author

zmoog commented Nov 13, 2025

@elastic/security-service-integrations, could you take a look at this PR when you have time?

@zmoog zmoog force-pushed the integrations-raw-events-v2 branch from b4ffb98 to 27ab064 Compare November 13, 2025 21:29
@zmoog zmoog enabled auto-merge (squash) November 13, 2025 21:29
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the background in the commit message would be helpful.

zmoog and others added 4 commits November 17, 2025 22:45
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
# Conflicts:
#	packages/azure/changelog.yml
#	packages/azure/manifest.yml
@zmoog zmoog force-pushed the integrations-raw-events-v2 branch from 648b982 to b494949 Compare November 17, 2025 21:46
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is waiting for obs-ds-hosted-services, but LGTM.

{{#if processor_update_interval}}
processor_update_interval: {{processor_update_interval}}
{{/if}}
{{#if processor_start_position}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add sth like if processor_version}==v2 then processor_start_position?

Same also for below fields that are only realted to v2

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a couple of checklist items for this in the next issue #15703, so I can do the same across all the integrations using this input.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the built-in helper #if only supports checking if a value is empty to skip rendering a block:

From https://handlebarsjs.com/guide/builtin-helpers.html#if:

You can use the if helper to conditionally render a block. If its argument returns false, undefined, null, "", 0, or [], Handlebars will not render the block.

This problem should auto-resolve soon as we are switching to processor v2 as default and dropping v1 after that.

Updated all the occurrences of the following config options:

- `processor_version`
- `processor_start_position`
Copy link
Contributor Author

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switched to type: select UI element in Azure Logs and Custom Azure Logs integrations.

The built-in helper #if doesn't seem to support expressions though.

{{#if processor_update_interval}}
processor_update_interval: {{processor_update_interval}}
{{/if}}
{{#if processor_start_position}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also added a couple of checklist items for this in the next issue #15703, so I can do the same across all the integrations using this input.

{{#if processor_update_interval}}
processor_update_interval: {{processor_update_interval}}
{{/if}}
{{#if processor_start_position}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the built-in helper #if only supports checking if a value is empty to skip rendering a block:

From https://handlebarsjs.com/guide/builtin-helpers.html#if:

You can use the if helper to conditionally render a block. If its argument returns false, undefined, null, "", 0, or [], Handlebars will not render the block.

This problem should auto-resolve soon as we are switching to processor v2 as default and dropping v1 after that.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @zmoog

@zmoog zmoog requested review from gizas and kaiyan-sheng November 19, 2025 09:14
@andrewkroh andrewkroh added the Integration:azure_logs Custom Azure Logs label Nov 19, 2025
@zmoog zmoog merged commit 2d1bf6b into main Nov 19, 2025
7 checks passed
@zmoog zmoog deleted the integrations-raw-events-v2 branch November 19, 2025 13:16
@elastic-vault-github-plugin-prod

Package azure - 1.30.0 containing this change is available at https://epr.elastic.co/package/azure/1.30.0/

@elastic-vault-github-plugin-prod

Package azure_logs - 0.4.2 containing this change is available at https://epr.elastic.co/package/azure_logs/0.4.2/

tehbooom pushed a commit to tehbooom/integrations that referenced this pull request Nov 19, 2025
…(v1) (elastic#15900)

Add the processor version option to the Raw Events integration v1. With these new options, users can switch from processor v1 (current default) to the processor v2.

This change anticipate the switch to v2 as default processor.
@andrewkroh andrewkroh added the enhancement New feature or request label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:azure_logs Custom Azure Logs Integration:azure Azure Logs Team:obs-ds-hosted-services Observability Hosted Services team [elastic/obs-ds-hosted-services] Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants