Skip to content

Conversation

@chemamartinez
Copy link
Contributor

Proposed commit message

API specifications for Google Threat Lists changed the availability time range of generated lists from one hour to two hours back.

Threat Lists are hourly generated as IoCs packages, with 2 hours difference from the current time. This means that if the current time in UTC is T you can get T-2h Threat List but any more recent than that.

Default initial intervals have been updated to align with that requirement.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@chemamartinez chemamartinez self-assigned this Nov 27, 2025
@chemamartinez chemamartinez added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:ti_google_threat_intelligence Google Threat Intelligence (Partner supported) labels Nov 27, 2025
@chemamartinez chemamartinez marked this pull request as ready for review November 27, 2025 15:21
@chemamartinez chemamartinez requested a review from a team as a code owner November 27, 2025 15:21
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Nov 27, 2025
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For initial_interval and interval, we should consider the duration type with min_duration option to help with such validations.

@chemamartinez
Copy link
Contributor Author

Thanks, @kcreddy

For initial_interval and interval, we should consider the duration type with min_duration option to help with such validations.

It is a good point, the problem I see right now is that would force the integration to bump its minimum Kibana version to 9.2.0, and this is related to an SDH so I'd wait to add this change for now.

"limit": ["4000"],
"x-tool": ["Elastic"],
"User-Agent": ["v0.6.1"], // Keep this in sync with 'version' in package level manifest.yml.
"User-Agent": ["v0.7.0"], // Keep this in sync with 'version' in package level manifest.yml.
Copy link
Contributor

@kcreddy kcreddy Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"User-Agent": ["v0.7.0"], // Keep this in sync with 'version' in package level manifest.yml.
"User-Agent": ["v0.8.0"], // Keep this in sync with 'version' in package level manifest.yml.

Nit.
@chemamartinez, please update them accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reminder!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chemamartinez

@chemamartinez chemamartinez merged commit 205a288 into elastic:main Dec 2, 2025
8 checks passed
@chemamartinez chemamartinez deleted the ti_google_threat_intelligence-fix-default-initial-interval branch December 2, 2025 15:48
@elastic-vault-github-plugin-prod

Package ti_google_threat_intelligence - 0.8.0 containing this change is available at https://epr.elastic.co/package/ti_google_threat_intelligence/0.8.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:ti_google_threat_intelligence Google Threat Intelligence (Partner supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants