-
Notifications
You must be signed in to change notification settings - Fork 519
ti_google_threat_intelligence: update default initial interval #16145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ti_google_threat_intelligence: update default initial interval #16145
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For initial_interval and interval, we should consider the duration type with min_duration option to help with such validations.
|
Thanks, @kcreddy
It is a good point, the problem I see right now is that would force the integration to bump its minimum Kibana version to 9.2.0, and this is related to an SDH so I'd wait to add this change for now. |
| "limit": ["4000"], | ||
| "x-tool": ["Elastic"], | ||
| "User-Agent": ["v0.6.1"], // Keep this in sync with 'version' in package level manifest.yml. | ||
| "User-Agent": ["v0.7.0"], // Keep this in sync with 'version' in package level manifest.yml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "User-Agent": ["v0.7.0"], // Keep this in sync with 'version' in package level manifest.yml. | |
| "User-Agent": ["v0.8.0"], // Keep this in sync with 'version' in package level manifest.yml. |
Nit.
@chemamartinez, please update them accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the reminder!
💚 Build Succeeded
History
|
|
Package ti_google_threat_intelligence - 0.8.0 containing this change is available at https://epr.elastic.co/package/ti_google_threat_intelligence/0.8.0/ |
Proposed commit message
API specifications for Google Threat Lists changed the availability time range of generated lists from one hour to two hours back.
Default initial intervals have been updated to align with that requirement.
Checklist
changelog.ymlfile.