Skip to content

Conversation

@hellqvio86
Copy link
Contributor

@hellqvio86 hellqvio86 commented Nov 28, 2025

Current HAProxy integration do not support BADREQ, e.g:

"message": "127.0.0.1 [29/Sep/2025:08:33:00.277] f_foobar~ f_foobar/<NOSRV> -1/-1/-1/-1/0 400 0 - - CR-- 8/1/0/0/0 0/0 \"<BADREQ>\""

Adding a guard to GROK-parsing of haproxy.http.request.raw_request_line so it does not run for BADREQ.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

@hellqvio86 hellqvio86 marked this pull request as ready for review November 28, 2025 11:48
@hellqvio86 hellqvio86 requested a review from a team as a code owner November 28, 2025 11:48
@andrewkroh andrewkroh added Integration:haproxy HAProxy Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 28, 2025
@shmsr
Copy link
Member

shmsr commented Dec 17, 2025

Thank you for fixing the issue as I was about to say that you have to handle and not BADREQ

@shmsr shmsr changed the title Support for BADREQ for HAProxy [HAProxy]: Fix parsing of logs containing <BADREQ> in the request line Dec 17, 2025
@shmsr shmsr added the bugfix Pull request that fixes a bug issue label Dec 17, 2025
Co-authored-by: subham s <sarkar.subhams2@gmail.com>
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests.

@ishleenk17 ishleenk17 enabled auto-merge (squash) December 17, 2025 18:30
@shmsr
Copy link
Member

shmsr commented Dec 18, 2025

@hellqvio86 Let's not "Update branch" again and again, let us wait for all CI checks to finish; otherwise it will take a lot of time. Let's wait for this one and when buildkite/integrations is done, do merge it. Also it is set to Auto Merge, no need to Update Branch then.

Just wait the CI checks to finish, and it would merge on its own.

@hellqvio86
Copy link
Contributor Author

@shmsr buildkite/integrations has been stuck in one pending check for over three weeks now, anything I can do? 🙂

@shmsr
Copy link
Member

shmsr commented Jan 8, 2026

@shmsr buildkite/integrations has been stuck in one pending check for over three weeks now, anything I can do? 🙂

This is weird. I am sorry I did not see this before. Let me get this checked today. I have re-run the jobs; let's see.

@shmsr
Copy link
Member

shmsr commented Jan 13, 2026

buildkite test it

@elasticmachine
Copy link

💚 Build Succeeded

cc @hellqvio86

@ishleenk17 ishleenk17 merged commit db7a1d5 into elastic:main Jan 13, 2026
8 checks passed
@elastic-vault-github-plugin-prod

Package haproxy - 1.17.2 containing this change is available at https://epr.elastic.co/package/haproxy/1.17.2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:haproxy HAProxy Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants