-
Notifications
You must be signed in to change notification settings - Fork 525
[HAProxy]: Fix parsing of logs containing <BADREQ> in the request line #16155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HAProxy]: Fix parsing of logs containing <BADREQ> in the request line #16155
Conversation
packages/haproxy/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
|
Thank you for fixing the issue as I was about to say that you have to handle and not BADREQ |
Co-authored-by: subham s <sarkar.subhams2@gmail.com>
ishleenk17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests.
|
@hellqvio86 Let's not "Update branch" again and again, let us wait for all CI checks to finish; otherwise it will take a lot of time. Let's wait for this one and when buildkite/integrations is done, do merge it. Also it is set to Auto Merge, no need to Update Branch then. Just wait the CI checks to finish, and it would merge on its own. |
|
@shmsr buildkite/integrations has been stuck in one pending check for over three weeks now, anything I can do? 🙂 |
This is weird. I am sorry I did not see this before. Let me get this checked today. I have re-run the jobs; let's see. |
|
buildkite test it |
💚 Build Succeeded
cc @hellqvio86 |
|
Package haproxy - 1.17.2 containing this change is available at https://epr.elastic.co/package/haproxy/1.17.2/ |
Current HAProxy integration do not support BADREQ, e.g:
Adding a guard to GROK-parsing of haproxy.http.request.raw_request_line so it does not run for BADREQ.
Checklist
changelog.ymlfile.