Skip to content

Conversation

@a03nikki
Copy link
Contributor

@a03nikki a03nikki commented Dec 18, 2025

Proposed commit message

Add support for OAuth2Endpoint Params option for alert and incident data streams.

The Alert and Incident data streams use the httpjson input type. This pull request adds the parameter along with the http mocks to test the parameters.

The configuration changes were heavily copied from previous Microsoft integration updates including #15667, #14924, and #15749.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • Not applicable

How to test this PR locally

Use Kibana to validate the parameters are presented.

Related issues

Screenshots

None taken

@a03nikki a03nikki self-assigned this Dec 18, 2025
@a03nikki a03nikki added the enhancement New feature or request label Dec 18, 2025
@a03nikki a03nikki requested a review from a team as a code owner December 18, 2025 22:28
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Dec 18, 2025

🚀 Benchmarks report

Package m365_defender 👍(3) 💚(2) 💔(3)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
incident 1077.59 840.41 -237.18 (-22.01%) 💔
alert 893.66 715.31 -178.35 (-19.96%) 💔
event 634.92 521.92 -113 (-17.8%) 💔

To see the full report comment with /test benchmark fullreport

@narph narph added Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Dec 19, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice to have system tests covering this and I think it's enough.

But it wouldn't hurt to have policy tests as well.
Here's an example from o365: it confirms that this config gets rendered like this in the policy.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @a03nikki

@a03nikki a03nikki merged commit f4c7578 into main Dec 20, 2025
8 checks passed
@a03nikki a03nikki deleted the m365_defender-oauth2-params branch December 20, 2025 00:23
@elastic-vault-github-plugin-prod

Package m365_defender - 5.4.0 containing this change is available at https://epr.elastic.co/package/m365_defender/5.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:m365_defender Microsoft Defender XDR Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants