-
Notifications
You must be signed in to change notification settings - Fork 524
Add M365 defender oauth2 params for incident and alert #16628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
incident |
1077.59 | 840.41 | -237.18 (-22.01%) | 💔 |
alert |
893.66 | 715.31 | -178.35 (-19.96%) | 💔 |
event |
634.92 | 521.92 | -113 (-17.8%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice to have system tests covering this and I think it's enough.
But it wouldn't hurt to have policy tests as well.
Here's an example from o365: it confirms that this config gets rendered like this in the policy.
Co-authored-by: Chris Berkhout <chris.berkhout@elastic.co>
…tic/integrations into m365_defender-oauth2-params
💚 Build Succeeded
History
cc @a03nikki |
|
Package m365_defender - 5.4.0 containing this change is available at https://epr.elastic.co/package/m365_defender/5.4.0/ |
Proposed commit message
Add support for OAuth2Endpoint Params option for alert and incident data streams.
The Alert and Incident data streams use the httpjson input type. This pull request adds the parameter along with the http mocks to test the parameters.
The configuration changes were heavily copied from previous Microsoft integration updates including #15667, #14924, and #15749.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Use Kibana to validate the parameters are presented.
Related issues
Screenshots
None taken