cloud_asset_inventory: Mark gcp_credentials_cloud_connector_id as secret#17377
cloud_asset_inventory: Mark gcp_credentials_cloud_connector_id as secret#17377Omolola-Akinleye merged 3 commits intomainfrom
Conversation
Vale Linting ResultsSummary: 3 suggestions found 💡 Suggestions (3)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
There was a problem hiding this comment.
Pull request overview
Updates the cloud_asset_inventory integration package to treat gcp_credentials_cloud_connector_id as a secret value (masked/secured in Fleet policy), along with the associated pre-release version bump.
Changes:
- Bump
cloud_asset_inventorypackage version to1.5.0-preview03. - Mark
gcp_credentials_cloud_connector_idassecret: truein the asset_inventory data stream manifest. - Add a
1.5.0-preview03changelog entry (and add a new_devinvestigation note).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
packages/cloud_asset_inventory/manifest.yml |
Bumps package version to 1.5.0-preview03. |
packages/cloud_asset_inventory/data_stream/asset_inventory/manifest.yml |
Marks gcp_credentials_cloud_connector_id as a secret var. |
packages/cloud_asset_inventory/changelog.yml |
Adds release note for 1.5.0-preview03. |
packages/cloud_asset_inventory/_dev/ci-regression-investigation.md |
Adds internal CI regression investigation notes under _dev. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - version: "1.5.0-preview03" | ||
| changes: | ||
| - description: Mark gcp_credentials_cloud_connector_id as secret | ||
| type: enhancement |
There was a problem hiding this comment.
The new 1.5.0-preview03 changelog entry is missing a link: field, while every other entry in this package’s changelog includes a PR link. Add the PR URL to keep the changelog consistent and to avoid breaking any tooling that expects the link metadata.
| # CI regression: cloud_security_posture (9.4 stack) passed Feb 3, broke after | ||
|
|
||
| ## What we know | ||
|
|
||
| - **PR 17185** (Cloud Security Posture – GCP Cloud Connectors) **CI passed on Feb 3rd** with elastic-package 0.118 and 9.4.0 stack. | ||
| - Same check (**Check integrations cloud_security_posture**) **fails now** (week of Feb 10). |
There was a problem hiding this comment.
This PR’s description is scoped to marking gcp_credentials_cloud_connector_id as secret and bumping the package version, but it also adds a CI regression investigation document about cloud_security_posture. Consider moving this note to a separate PR (or updating the PR description) to keep the change set focused and easier to track in history.
💚 Build Succeeded
|
|
Package cloud_asset_inventory - 1.5.0-preview03 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/1.5.0-preview03/ |
…ret (elastic#17377) * Mark gcp_credentials_cloud_connector_id as secret (1.5.0-preview03) * Add PR link to changelog * Remove accidentally included _dev/ci-regression-investigation.md
|
Package cloud_asset_inventory - 1.5.0-preview04 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/1.5.0-preview04/ |
|
Package cloud_asset_inventory - 1.5.0 containing this change is available at https://epr.elastic.co/package/cloud_asset_inventory/1.5.0/ |
Summary
gcp_credentials_cloud_connector_idas secret in asset_inventory manifest.