[activemq_otel] ActiveMQ OpenTelemetry assets#17635
[activemq_otel] ActiveMQ OpenTelemetry assets#17635Linu-Elias merged 11 commits intoelastic:mainfrom
Conversation
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
andrewkroh
added
dashboard
|
Claude finished @ishleenk17's task in 2m 57s —— View job Reviewing PR based on #17520 feedback
I've submitted a PR review based on the feedback patterns from PR #17520 (nginx_otel). Summary of findings:
What's good (based on #17520 patterns):
See the full PR review for details. --- | Branch: Why is Claude responding? | Type Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Based on the review patterns from PR #17520 (nginx_otel), I've reviewed this PR and found a few items that should be addressed:
Issues found in large JSON files (cannot add inline comments):
- Dashboard title has '(1)' suffix (
activemq_otel-broker-health.json:2543)- The title is
"[ActiveMQ OTel] Broker Health & Capacity (1)"- the(1)suffix appears to be a copy artifact and should be removed.
- The title is
Positive observations (compared to nginx_otel feedback):
- ✅ The package correctly uses "Assets" terminology instead of "Integration" (per feedback in #17520)
- ✅ Naming convention
[ActiveMQ OTel]is consistently applied across all dashboards, alert rules, and SLO templates - ✅ No
insecure_skip_verify: truesetting in documentation (this was flagged in #17520) - ✅ Data stream name
activemq.otelis documented in README and properly referenced in manifest discovery - ✅ ESQL queries are being used in alerting rule templates
- ✅ CODEOWNERS entry is properly added
Note about the PR checklist:
The Kibana version constraints checkbox is unchecked. Please verify if ^9.2.3 is the correct current version per the guidelines.
Why is Claude responding? | Type @claude to interact further
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
|
@Linu-Elias : Are no control filters required for the dashboards. We would not want to provide filtering to the customers for the dashboards. |
|
@Linu-Elias The Y axis for file descriptors should be updated. |
|
To make this compatible with kb-dashboard 0.4.0 (released 3/17), run the automated upgrade and recompile: # 1. Upgrade YAML files in-place (handles all schema renames automatically)
uvx kb-dashboard-cli upgrade --write --input-dir packages/<PACKAGE>/_dev/shared/kibana
# 2. Recompile
uvx kb-dashboard-cli compile \
--input-dir packages/<PACKAGE>/_dev/shared/kibana \
--output-dir packages/<PACKAGE>/kibana/dashboard \
--format jsonThe
Review the diff after upgrading to confirm the changes look correct, then recompile and commit. |
|
I ran Results
Upgrade and post-upgrade compile succeeded with 0.4.0. Suggested commands: uvx --from kb-dashboard-cli==0.4.0 kb-dashboard upgrade --input-dir packages/activemq_otel/_dev/shared/kibana --write
uvx --from kb-dashboard-cli==0.4.0 kb-dashboard compile --input-dir packages/activemq_otel/_dev/shared/kibana --output-dir packages/activemq_otel/kibana/dashboard --format elastic-integrations |
💚 Build Succeeded
History
|
|
@Linu-Elias : Y axis of couple of panels needs changes. |
@ishleenk17, Sorry I missed updating the dashboard screenshots in the description. PTAL again. |
|
Package activemq_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/activemq_otel/0.1.0/ |
5 participants
Enhancement
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots