Skip to content

feat: add etcd otel content pack#17757

Merged
ishleenk17 merged 18 commits intoelastic:mainfrom
stefans-elastic:etcd-cp
Apr 8, 2026
Merged

feat: add etcd otel content pack#17757
ishleenk17 merged 18 commits intoelastic:mainfrom
stefans-elastic:etcd-cp

Conversation

@stefans-elastic
Copy link
Copy Markdown
Contributor

Proposed commit message

See title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@stefans-elastic stefans-elastic requested a review from a team as a code owner March 11, 2026 15:46
@stefans-elastic stefans-elastic added enhancement New feature or request Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Mar 11, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 11, 2026

Vale Linting Results

Summary: 2 warnings found

⚠️ Warnings (2)
File Line Rule Message
packages/etcd_otel/docs/README.md 5 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.
packages/etcd_otel/docs/README.md 26 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'.

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@andrewkroh andrewkroh added New Integration Issue or pull request for creating a new integration package. dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. labels Mar 15, 2026
@strawgate
Copy link
Copy Markdown
Contributor

strawgate commented Mar 16, 2026

To make this compatible with kb-dashboard 0.4.0 (released 3/17), run the automated upgrade and recompile:

# 1. Upgrade YAML files in-place (handles all schema renames automatically)
uvx kb-dashboard-cli upgrade --write --input-dir packages/<PACKAGE>/_dev/shared/kibana

# 2. Recompile
uvx kb-dashboard-cli compile \
  --input-dir packages/<PACKAGE>/_dev/shared/kibana \
  --output-dir packages/<PACKAGE>/kibana/dashboard \
  --format json

The upgrade command automatically handles:

  • dimensionsbreakdowns (pie, treemap, datatable)
  • dimensionbreakdown (waffle)
  • dimensions_bymetrics_split_by (datatable)
  • titles_and_textappearance fields (pie, mosaic, waffle, XY)
  • legend.sizelegend.width
  • appearance.shape camelCase → snake_case (gauge)
  • color.stopscolor.thresholds with stopup_to (gauge)
  • Static numeric minimum/maximum/goal → EVAL expressions (ESQL gauge)

Review the diff after upgrading to confirm the changes look correct, then recompile and commit.

@stefans-elastic
Copy link
Copy Markdown
Contributor Author

Upgraded the dashboards to make them compatible with kb-dashboard 0.4.0

@strawgate
Copy link
Copy Markdown
Contributor

I ran kb-dashboard 0.4.0 upgrade validation on this PR in an isolated worktree.

Results

  • packages/etcd_otel/_dev/shared/kibana
    • upgrade --fail-on-change exit: 0
    • upgrade --write exit: 0
    • post-upgrade compile --format elastic-integrations exit: 0

Upgrade and post-upgrade compile succeeded with 0.4.0.
Please apply these commands in your branch and commit both YAML + regenerated JSON artifacts.

Suggested commands:

uvx --from kb-dashboard-cli==0.4.0 kb-dashboard upgrade --input-dir packages/etcd_otel/_dev/shared/kibana --write
uvx --from kb-dashboard-cli==0.4.0 kb-dashboard compile --input-dir packages/etcd_otel/_dev/shared/kibana --output-dir packages/etcd_otel/kibana/dashboard --format elastic-integrations

@stefans-elastic
Copy link
Copy Markdown
Contributor Author

I ran kb-dashboard 0.4.0 upgrade validation on this PR in an isolated worktree.

Results

  • packages/etcd_otel/_dev/shared/kibana

    • upgrade --fail-on-change exit: 0
    • upgrade --write exit: 0
    • post-upgrade compile --format elastic-integrations exit: 0

Upgrade and post-upgrade compile succeeded with 0.4.0. Please apply these commands in your branch and commit both YAML + regenerated JSON artifacts.

Suggested commands:

uvx --from kb-dashboard-cli==0.4.0 kb-dashboard upgrade --input-dir packages/etcd_otel/_dev/shared/kibana --write
uvx --from kb-dashboard-cli==0.4.0 kb-dashboard compile --input-dir packages/etcd_otel/_dev/shared/kibana --output-dir packages/etcd_otel/kibana/dashboard --format elastic-integrations

done

@shmsr shmsr requested a review from a team March 19, 2026 08:49
Copy link
Copy Markdown
Contributor

@mykola-elastic mykola-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The percent calculation in some queries is OK, in some is off by *100 (see comments)
  • I am not sure that SUM(RATE(cumulative_field)) becomes rate of field (see comments)
  • The OTel config example doesn't include resource processor to add data stream name of etcd.otel which is used in the assets
  • Alerting rule templates have ratio calculations (division), please make confirm that those are not integer divisions

@muthu-mps
Copy link
Copy Markdown
Contributor

@stefans-elastic -
Can you check the overview dashboard panels below?

  1. Has Leader by Instance. Should this be Leader by Instance? Also if we represent the count then the panel should be updated to display exact number format values.
  2. Leader Changes Seen. Should this be Leader Changes?

@muthu-mps
Copy link
Copy Markdown
Contributor

Can you confirm whether we are able to install an Alerting Rule in 9.2.1 stack version? This is to make sure that everything works fine with the minimum supported stack version.

@stefans-elastic
Copy link
Copy Markdown
Contributor Author

Can you confirm whether we are able to install an Alerting Rule in 9.2.1 stack version? This is to make sure that everything works fine with the minimum supported stack version.

yes, I was able to install an Alerting Rule in 9.2.1.
Screenshot 2026-04-07 at 12 44 28

@stefans-elastic
Copy link
Copy Markdown
Contributor Author

@stefans-elastic - Can you check the overview dashboard panels below?

  1. Has Leader by Instance. Should this be Leader by Instance? Also if we represent the count then the panel should be updated to display exact number format values.
  2. Leader Changes Seen. Should this be Leader Changes?

@muthu-mps

  • "Has Leader by Instance" → Renamed to "Leader by Instance" and updated the metric label from "Has Leader" to "Leader".
    I kept decimals: 1 for the number format — with decimals: 0 Kibana renders duplicate tick labels on the Y-axis (multiple fractional ticks round to the same integer). Since the axis is bounded to 0–1, the values display as 0.0 and 1.0 which are still unambiguous.
  • "Leader Changes Seen (cumulative)" → Renamed to "Leader Changes Seen", dropping the "(cumulative)" suffix since the query actually computes a rate (SUM(RATE(...))), not a cumulative value. Kept "Seen" to stay consistent with the underlying metric name etcd_server_leader_changes_seen_total.

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

@ishleenk17 ishleenk17 merged commit 068fce4 into elastic:main Apr 8, 2026
12 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package etcd_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/etcd_otel/0.1.0/

@andrewkroh andrewkroh added the Integration:etcd_otel etcd OpenTelemetry Assets label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Relates to a Kibana dashboard bug, enhancement, or modification. documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:etcd_otel etcd OpenTelemetry Assets New Integration Issue or pull request for creating a new integration package. Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants