[redisenterprise_otel] Add redisenterprise_otel content pack#18002
[redisenterprise_otel] Add redisenterprise_otel content pack#18002ishleenk17 merged 4 commits intoelastic:mainfrom
Conversation
Vale Linting ResultsSummary: 3 warnings, 1 suggestion found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/redisenterprise_otel/docs/README.md | 35 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/redisenterprise_otel/docs/README.md | 36 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/redisenterprise_otel/docs/README.md | 37 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
💡 Suggestions (1)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/redisenterprise_otel/docs/README.md | 119 | Elastic.WordChoice | Consider using 'can, might' instead of 'may', unless the term is in the UI. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
andrewkroh
added
New Integration
|
Can you fix the null values in the table? |
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
| - FROM metrics-redisenterprise.otel-default | ||
| - WHERE bdb_shard_cpu_user IS NOT NULL |
There was a problem hiding this comment.
🟡 Medium kibana/redisenterprise_otel-database-performance.yaml:576
The EVAL expression at line 578 adds bdb_shard_cpu_system to bdb_shard_cpu_user, but the WHERE clause only filters on bdb_shard_cpu_user IS NOT NULL. When bdb_shard_cpu_system is NULL, the addition produces NULL and those data points are silently dropped from the chart. Consider adding AND bdb_shard_cpu_system IS NOT NULL to the WHERE clause.
- - WHERE bdb_shard_cpu_user IS NOT NULL
+ - WHERE bdb_shard_cpu_user IS NOT NULL AND bdb_shard_cpu_system IS NOT NULL🤖 Copy this AI Prompt to have your agent fix this:
In file packages/redisenterprise_otel/_dev/shared/kibana/redisenterprise_otel-database-performance.yaml around lines 576-577:
The EVAL expression at line 578 adds `bdb_shard_cpu_system` to `bdb_shard_cpu_user`, but the WHERE clause only filters on `bdb_shard_cpu_user IS NOT NULL`. When `bdb_shard_cpu_system` is NULL, the addition produces NULL and those data points are silently dropped from the chart. Consider adding `AND bdb_shard_cpu_system IS NOT NULL` to the WHERE clause.
| type: line | ||
| query: | ||
| - FROM metrics-redisenterprise.otel-default | ||
| - WHERE bdb_avg_latency_max IS NOT NULL |
There was a problem hiding this comment.
🟠 High kibana/redisenterprise_otel-database-performance.yaml:264
The Max Latency Over Time panel filters on bdb_avg_latency_max IS NOT NULL, but this field doesn't exist — the actual fields are bdb_avg_read_latency_max, bdb_avg_write_latency_max, and bdb_avg_other_latency_max. The query will never match documents, so the panel always displays empty. Consider filtering on bdb_avg_read_latency_max IS NOT NULL instead, matching the pattern used in the non-max latency panel.
| - WHERE bdb_avg_latency_max IS NOT NULL | |
| - WHERE bdb_avg_read_latency_max IS NOT NULL |
🤖 Copy this AI Prompt to have your agent fix this:
In file packages/redisenterprise_otel/_dev/shared/kibana/redisenterprise_otel-database-performance.yaml around line 264:
The `Max Latency Over Time` panel filters on `bdb_avg_latency_max IS NOT NULL`, but this field doesn't exist — the actual fields are `bdb_avg_read_latency_max`, `bdb_avg_write_latency_max`, and `bdb_avg_other_latency_max`. The query will never match documents, so the panel always displays empty. Consider filtering on `bdb_avg_read_latency_max IS NOT NULL` instead, matching the pattern used in the non-max latency panel.
| - FROM metrics-redisenterprise.otel-default | ||
| - WHERE bdb_read_hits IS NOT NULL | ||
| - STATS hits = AVG(bdb_read_hits), misses = AVG(bdb_read_misses) BY bdb | ||
| - EVAL hit_rate = ROUND((hits / (hits + misses)) * 100, 1) |
There was a problem hiding this comment.
🟠 High kibana/redisenterprise_otel-overview.yaml:304
The EVAL hit_rate formula on line 304 divides by hits + misses without guarding against zero. When a database has no read activity, both values are 0, causing division by zero that produces null/NaN and breaks panel rendering. Consider adding a zero-guard using CASE or ensuring the denominator is non-zero before division.
- - EVAL hit_rate = ROUND((hits / (hits + misses)) * 100, 1)
+ - EVAL hit_rate = CASE(hits + misses > 0, ROUND((hits / (hits + misses)) * 100, 1), 0)🤖 Copy this AI Prompt to have your agent fix this:
In file packages/redisenterprise_otel/_dev/shared/kibana/redisenterprise_otel-overview.yaml around line 304:
The `EVAL hit_rate` formula on line 304 divides by `hits + misses` without guarding against zero. When a database has no read activity, both values are 0, causing division by zero that produces null/NaN and breaks panel rendering. Consider adding a zero-guard using `CASE` or ensuring the denominator is non-zero before division.
💚 Build Succeeded
History
|
|
Package redisenterprise_otel - 0.1.0 containing this change is available at https://epr.elastic.co/package/redisenterprise_otel/0.1.0/ |
andrewkroh
added
the
Integration:redisenterprise_otel
5 participants
Proposed commit message
See title
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots