checkpoint_email: shorten expiry period to avoid expiration races#18021
Merged
efd6 merged 1 commit intoelastic:mainfrom Mar 25, 2026
Merged
checkpoint_email: shorten expiry period to avoid expiration races#18021efd6 merged 1 commit intoelastic:mainfrom
efd6 merged 1 commit intoelastic:mainfrom
Conversation
There is a TOCTOU race in the token expiration, so shorted to lifetime of the token by a small amount to avoid this.
8af7d1e to
7787404
Compare
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
@macroscope-app review |
|
All code reviews were skipped. View the details here: |
kcreddy
approved these changes
Mar 25, 2026
Contributor
Looks like it doesn't work on forks anymore. |
|
Package checkpoint_email - 1.4.0 containing this change is available at https://epr.elastic.co/package/checkpoint_email/1.4.0/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots