Skip to content

checkpoint_email: shorten expiry period to avoid expiration races#18021

Merged
efd6 merged 1 commit intoelastic:mainfrom
efd6:17829-checkpoint_email
Mar 25, 2026
Merged

checkpoint_email: shorten expiry period to avoid expiration races#18021
efd6 merged 1 commit intoelastic:mainfrom
efd6:17829-checkpoint_email

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Mar 25, 2026

Proposed commit message

checkpoint_email: shorten expiry period to avoid expiration races

There is a TOCTOU race in the token expiration, so shorten the lifetime
of the token by a small amount to avoid this.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Mar 25, 2026
@efd6 efd6 added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:checkpoint_email Check Point Harmony Email & Collaboration labels Mar 25, 2026
There is a TOCTOU race in the token expiration, so shorted to lifetime
of the token by a small amount to avoid this.
@efd6 efd6 force-pushed the 17829-checkpoint_email branch from 8af7d1e to 7787404 Compare March 25, 2026 00:59
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review March 25, 2026 01:49
@efd6 efd6 requested a review from a team as a code owner March 25, 2026 01:49
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy
Copy link
Copy Markdown
Contributor

kcreddy commented Mar 25, 2026

@macroscope-app review

@macroscopeapp
Copy link
Copy Markdown

macroscopeapp bot commented Mar 25, 2026

All code reviews were skipped. View the details here:

@kcreddy
Copy link
Copy Markdown
Contributor

kcreddy commented Mar 25, 2026

All code reviews were skipped. View the details here:

Looks like it doesn't work on forks anymore.

@efd6 efd6 merged commit a81b928 into elastic:main Mar 25, 2026
10 checks passed
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package checkpoint_email - 1.4.0 containing this change is available at https://epr.elastic.co/package/checkpoint_email/1.4.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:checkpoint_email Check Point Harmony Email & Collaboration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants