[akamai] Fix Pipeline for Populating Http Message Headers#18205
[akamai] Fix Pipeline for Populating Http Message Headers#18205mohitjha-elastic merged 4 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
chrisberkhout
left a comment
There was a problem hiding this comment.
I put some comments about issues in the current implementation, but I think it would be better to switch to a different implementation that keeps the header values the same by placing some markers to support key-value splitting, rather than removing tricky content from the actual values. There's an implementation of that here:
1. Switch to gsub and kv only style. 2. Remove the script.
|
Thanks @chrisberkhout Non-parseable placeholders (e.g. {p}) are dropped with a remove processor when the string contains no :``, replacing the earlier painless blocks. Please review the updated pipeline logic and let me know what you think. |
💚 Build Succeeded
History
|
chrisberkhout
left a comment
There was a problem hiding this comment.
Thanks for making the suggested improvements!
I originally misunderstood the gsub. Replacing \r\n[\t ]+ with a single space gives us the original value by removing the obsolete line folding ( "obs-fold") defined in RFC 7230. That normalization doesn't change the semantic value, it just converts from the folded presentation into the canonical single-line form. So that's what we want.
|
Package akamai - 3.1.1 containing this change is available at https://epr.elastic.co/package/akamai/3.1.1/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally