Skip to content

[Hashicorp_vault] Add cluster_address as a dimension field to prevent duplicate document conflicts#18222

Merged
robester0403 merged 10 commits intoelastic:mainfrom
robester0403:hashicorp_vault-fix-dropped-logs
Apr 7, 2026
Merged

[Hashicorp_vault] Add cluster_address as a dimension field to prevent duplicate document conflicts#18222
robester0403 merged 10 commits intoelastic:mainfrom
robester0403:hashicorp_vault-fix-dropped-logs

Conversation

@robester0403
Copy link
Copy Markdown
Contributor

@robester0403 robester0403 commented Apr 4, 2026

Proposed commit message

Add cluster_address as a TSDS dimension field for the metrics data stream to prevent duplicate document conflicts when multiple Vault clusters are monitored.

Passes System Check
image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
    - [ ] I have verified that Kibana version constraints are current according to guidelines.
    - [ ] I have verified that any added dashboard complies with Kibana's Dashboard good practices

@robester0403 robester0403 self-assigned this Apr 4, 2026
@robester0403 robester0403 added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:hashicorp_vault Hashicorp Vault bugfix Pull request that fixes a bug issue Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience] labels Apr 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Vale Linting Results

Summary: 5 warnings found

⚠️ Warnings (5)
File Line Rule Message
packages/hashicorp_vault/docs/README.md 603 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.
packages/hashicorp_vault/docs/README.md 603 Elastic.QuotesPunctuation Place punctuation inside closing quotation marks.
packages/hashicorp_vault/docs/README.md 603 Elastic.QuotesPunctuation Place punctuation inside closing quotation marks.
packages/hashicorp_vault/docs/README.md 603 Elastic.QuotesPunctuation Place punctuation inside closing quotation marks.
packages/hashicorp_vault/docs/README.md 616 Elastic.Latinisms Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'.

The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@robester0403 robester0403 marked this pull request as ready for review April 4, 2026 18:37
@robester0403 robester0403 requested a review from a team as a code owner April 4, 2026 18:37
@elasticmachine
Copy link
Copy Markdown

Pinging @elastic/integration-experience (Team:Integration-Experience)

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please add descriptions to the new fields.

Comment thread packages/hashicorp_vault/data_stream/metrics/fields/fields.yml
Comment thread packages/hashicorp_vault/data_stream/metrics/fields/fields.yml
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Comment thread packages/hashicorp_vault/data_stream/audit/fields/fields.yml Outdated
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @robester0403

@robester0403 robester0403 merged commit 44fcd34 into elastic:main Apr 7, 2026
11 checks passed
@robester0403 robester0403 deleted the hashicorp_vault-fix-dropped-logs branch April 7, 2026 15:01
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package hashicorp_vault - 1.30.1 containing this change is available at https://epr.elastic.co/package/hashicorp_vault/1.30.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:hashicorp_vault Hashicorp Vault Team:Integration-Experience Security Integrations Integration Experience [elastic/integration-experience]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants