feat(crowdstrike): add identity protection assessment data stream#18237
feat(crowdstrike): add identity protection assessment data stream#18237navnit-elastic wants to merge 16 commits intoelastic:mainfrom
Conversation
Vale Linting ResultsSummary: 5 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/crowdstrike/docs/README.md | 3726 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/crowdstrike/docs/README.md | 3727 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'and so on' instead of 'etc'. |
| packages/crowdstrike/docs/README.md | 3729 | Elastic.QuotesPunctuation | Place punctuation inside closing quotation marks. |
| packages/crowdstrike/docs/README.md | 3730 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
| packages/crowdstrike/docs/README.md | 3731 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'for example' instead of 'e.g'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
50bedb5 to
ebe7297
Compare
add documentation add option to configure dataSources for domains add dashboard
ebe7297 to
f6c967c
Compare
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
falcon |
5555.56 | 3311.26 | -2244.3 (-40.4%) | 💔 |
host |
4484.3 | 3135.78 | -1348.52 (-30.07%) | 💔 |
alert |
1937.98 | 1607.72 | -330.26 (-17.04%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Add option to preserver duplicate custom fields Update dashboard
kcreddy
left a comment
There was a problem hiding this comment.
Just getting clarification on couple of script tests. Otherwise LGTM
There was a problem hiding this comment.
Isn't this the same as previous test first_assessment just with DOMAIN_B error instead of DOMAIN_A error? Do we need to test both?
There was a problem hiding this comment.
No, they are different. The intent is to test errors in sequence of requests (i.e. first request fails and second successes, first successes and second fails).
The first_assessment_http_500 validates that after a failure in a middle of work-list, the collector still continues and ingests event for the next domain.
The second_assessment_http_500 validates that when the first assessment succeeds but the second fails, we still get one assessment and one error.
If you think this is redundant and not required to test at this depth, we can skip the second_assessment_http_500 test case.
There was a problem hiding this comment.
Yeah, lets remove second_assessment_http_500 its testing the same code block
navnit-elastic
left a comment
There was a problem hiding this comment.
@kcreddy, Please take a look at comment replies.
There was a problem hiding this comment.
No, they are different. The intent is to test errors in sequence of requests (i.e. first request fails and second successes, first successes and second fails).
The first_assessment_http_500 validates that after a failure in a middle of work-list, the collector still continues and ingests event for the next domain.
The second_assessment_http_500 validates that when the first assessment succeeds but the second fails, we still get one assessment and one error.
If you think this is redundant and not required to test at this depth, we can skip the second_assessment_http_500 test case.
💚 Build Succeeded
History
|
Proposed commit message
Docs (Elastic tenant):
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots