jumpcloud: fix start_time errors when source_lag_time is configured#18245
Merged
kcreddy merged 4 commits intoelastic:mainfrom Apr 8, 2026
Merged
jumpcloud: fix start_time errors when source_lag_time is configured#18245kcreddy merged 4 commits intoelastic:mainfrom
kcreddy merged 4 commits intoelastic:mainfrom
Conversation
PR elastic#15432 (v1.17.0) added source_lag_time with a guard condition to clamp start_time when the cursor is ahead of now - source_lag_time. Two bugs in the implementation cause 400 Bad Request errors from the JumpCloud API: 1. parseDate uses the default RFC3339 layout, which cannot parse JumpCloud's fractional-second timestamps (e.g. 2023-01-14T08:16:06.495Z). When parsing fails, parseDate silently returns zero time, disabling the guard condition entirely. 2. The YAML >- block scalar introduces a trailing newline in the if-true branch output. When the guard fires, start_time is sent as "2025-04-01T09:45:26Z\n", which JumpCloud rejects as invalid. Fix (1) by passing "RFC3339Nano" layout to parseDate so it handles fractional seconds. Fix (2) by adding the -]] trim marker to strip the trailing newline. Add a system test configuration exercising the source_lag_time code path across multiple polling cycles.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @kcreddy |
|
Package jumpcloud - 1.17.1 containing this change is available at https://epr.elastic.co/package/jumpcloud/1.17.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.