[microsoft_sqlserver] upgrade to 2025 version#18262
Open
giorgi-imerlishvili-elastic wants to merge 8 commits into
Open
[microsoft_sqlserver] upgrade to 2025 version#18262giorgi-imerlishvili-elastic wants to merge 8 commits into
giorgi-imerlishvili-elastic wants to merge 8 commits into
Conversation
giorgi-imerlishvili-elastic
added
the
documentation
giorgi-imerlishvili-elastic
added
enhancement
Contributor
Vale Linting ResultsSummary: 4 warnings, 7 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/microsoft_sqlserver/_dev/build/docs/README.md | 52 | Elastic.DontUse | Don't use 'Please'. |
| packages/microsoft_sqlserver/docs/README.md | 52 | Elastic.DontUse | Don't use 'Please'. |
| packages/microsoft_sqlserver/docs/README.md | 247 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/microsoft_sqlserver/docs/README.md | 248 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
💡 Suggestions (7)
| File | Line | Rule | Message |
|---|---|---|---|
| packages/microsoft_sqlserver/_dev/build/docs/README.md | 158 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 158 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 556 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 685 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 686 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 687 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
| packages/microsoft_sqlserver/docs/README.md | 689 | Elastic.Wordiness | Consider using 'because' instead of 'since'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
🚀 Benchmarks reportTo see the full report comment with |
andrewkroh
added
the
Team:Obs-InfraObs
changes based on manual testing
jakubgalecki0
approved these changes
Apr 9, 2026
Contributor
|
@claude review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
I found one correctness issue in the new transaction log field mapping: pvs_pages_allocated is emitted as a page count but mapped with unit: byte. Please align either the mapping unit or the SQL value conversion before merge.
What is this? | From workflow: Mention in PR
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.
5 tasks
muthu-mps
reviewed
Apr 16, 2026
| type: keyword | ||
| dimension: true | ||
| description: Server name of the availability replica. | ||
| - name: role |
Contributor
There was a problem hiding this comment.
1 = PRIMARY, 2 = SECONDARY, NULL = not a local replica.
Does the null value processed or ignored?
Contributor
Author
There was a problem hiding this comment.
It will be ignored
| - version: "2.17.0" | ||
| changes: | ||
| - description: > | ||
| Add SQL Server 2022 and 2025 support. |
Contributor
There was a problem hiding this comment.
Can we make this readable?
4 tasks
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
5 tasks
💚 Build Succeeded
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add SQL Server 2022 and 2025 support.
availability_groups: collect per-replica state from sys.dm_hadr_availability_replica_states;
add is_contained (SQL 2022+), basic_availability_group (SQL 2016–2022, removed in SQL Server 2025),
and is_distributed (SQL 2016+) fields via sys.columns-guarded dynamic SQL so all three columns
return NULL instead of an error when absent on the running SQL Server version.
audit: add obo_middle_tier_app_id, obo_middle_tier_app_name, external_policy_permissions_checked fields (SQL 2022+);
add LEDGER_OPERATION_GROUP, EXTERNAL_POLICY_OPERATION_GROUP (SQL 2022), VECTOR_OPERATION_GROUP, and
EXTERNAL_REST_ENDPOINT_GROUP (SQL 2025) audit action group mappings.
performance: add external_rest_endpoint_total_executions counter via SQLServer:External REST Endpoint (SQL 2025+).
transaction_log: add ADR Persistent Version Store (PVS) metrics from
sys.dm_tran_persistent_version_store_stats (SQL 2022+) via version-safe dynamic SQL.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots