[ti_rapid7_threat_command] Add Agentless Deployment#18331
[ti_rapid7_threat_command] Add Agentless Deployment#18331mohitjha-elastic merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🚀 Benchmarks reportTo see the full report comment with |
| team: security-service-integrations | ||
| resources: | ||
| requests: | ||
| memory: 4Gi |
There was a problem hiding this comment.
That's a lot of memory. How was this number determined?
There was a problem hiding this comment.
This decision to move to 4GiB does not seem to be backed by data. Can we ship it with the defaults to start with an increase it if there is a problem? Or do you have specific evidence that rapid7 requires 4Gi?
There was a problem hiding this comment.
@andrewkroh We do not observe any issue while testing. Updated it to use the default memory. Thanks!
💚 Build Succeeded
History
|
|
Package ti_rapid7_threat_command - 2.8.0 containing this change is available at https://epr.elastic.co/package/ti_rapid7_threat_command/2.8.0/ |
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues