Properly populate file.* fields for network share events#18348
Merged
brian-mckinney merged 6 commits intoelastic:mainfrom Apr 23, 2026
Merged
Properly populate file.* fields for network share events#18348brian-mckinney merged 6 commits intoelastic:mainfrom
brian-mckinney merged 6 commits intoelastic:mainfrom
Conversation
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
powershell_operational |
2570.69 | 1561.52 | -1009.17 (-39.26%) | 💔 |
powershell_operational |
2570.69 | 2118.64 | -452.05 (-17.58%) | 💔 |
To see the full report comment with /test benchmark fullreport
andrewkroh
added
Integration:system
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
rdner
approved these changes
Apr 16, 2026
Member
rdner
left a comment
rdner
left a comment
There was a problem hiding this comment.
LGTM
The macroscope comment should be double-checked.
nfritts
approved these changes
Apr 23, 2026
💚 Build Succeeded
History
|
|
Package system - 2.16.2 containing this change is available at https://epr.elastic.co/package/system/2.16.2/ |
|
Package windows - 3.8.2 containing this change is available at https://epr.elastic.co/package/windows/3.8.2/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Network share events were not correctly populating the file.* fields according to the ECS Schema.
These fields have a
ShareLocalPathand aRelativeTargetName, we were simply using those fields forfile.directoryandfile.namerespectively.RelativeTargetNamehowever is all parts of the path after the share name, including the filename. For example:ECS Schema says
file.nameshould be the name of the file including extension. This PR applies logic to the two fields to construct the full path and use that to populate the fields accordinglyChecklist
changelog.ymlfile.Related issues
Fixes: https://github.com/elastic/sdh-beats/issues/7064