[aws_sqs] enable agentless deployment for aws sqs metrics#18366
[aws_sqs] enable agentless deployment for aws sqs metrics#18366jakubgalecki0 merged 5 commits intoelastic:mainfrom
Conversation
| categories: | ||
| - observability | ||
| inputs: | ||
| - type: aws/metrics |
There was a problem hiding this comment.
IIRC, this metricset doesn't support load balancing—so if you run two instances with the same config they'll collect the same data.
Does agentless handle this scenario?
There was a problem hiding this comment.
As far as I understand in agentless mode we are responsible for running the agent but other than that it shouldn't differ much from standard agent based approach.
cc: @kpollich
There was a problem hiding this comment.
@zmoog: Are we talking about the scenario of multiple agents linked to 1 agent policy running the same config, polling the same CloudWatch namespace in the same region at the same time ?
Curioud how is duplication handled in case of agent based mode ?
One thing to note for agentless: It runs as 1 policy per pod. So 1 agent linked to 1 policy per pod. So if we have another instance of agent it would be part of a different policy and pod.
There was a problem hiding this comment.
@zmoog: Are we talking about the scenario of multiple agents linked to 1 agent policy running the same config, polling the same CloudWatch namespace in the same region at the same time?
Yes, this is the case: 1 agent policy assigned to 2+ agents.
Curioud how is duplication handled in case of agent based mode?
AFAIK, it's not handled. I think there aren't many integrations that can be assigned to multiple agents to scale out (in the cloud space, I know integrations based on aws-s3/sqs or azure-eventhub inputs can).
One thing to note for agentless: It runs as 1 policy per pod. So 1 agent linked to 1 policy per pod. So if we have another instance of agent it would be part of a different policy and pod.
Got it, thanks! Looking forward to learn more about agentless.
Vale Linting ResultsSummary: 2 warnings found
|
| File | Line | Rule | Message |
|---|---|---|---|
| packages/aws/_dev/build/docs/sqs.md | 35 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
| packages/aws/docs/sqs.md | 35 | Elastic.Latinisms | Latin terms and abbreviations are a common source of confusion. Use 'using' instead of 'via'. |
The Vale linter checks documentation changes against the Elastic Docs style guide.
To use Vale locally or report issues, refer to Elastic style guide for Vale.
andrewkroh
added
documentation
kcreddy
left a comment
kcreddy
left a comment
There was a problem hiding this comment.
LGTM after this minor change.
codeowner approval for aws package.
| changes: | ||
| - description: Enable agentless deployment for AWS SQS metrics. | ||
| type: enhancement | ||
| link: https://github.com/elastic/integrations/pull/18365 |
There was a problem hiding this comment.
| link: https://github.com/elastic/integrations/pull/18365 | |
| link: https://github.com/elastic/integrations/pull/18366 |
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
lambda_logs |
10638.3 | 8264.46 | -2373.84 (-22.31%) | 💔 |
route53_public_logs |
20408.16 | 15151.52 | -5256.64 (-25.76%) | 💔 |
securityhub_insights |
1506.02 | 1221 | -285.02 (-18.93%) | 💔 |
cloudfront_logs |
3322.26 | 2762.43 | -559.83 (-16.85%) | 💔 |
elb_logs |
652.74 | 530.22 | -122.52 (-18.77%) | 💔 |
To see the full report comment with /test benchmark fullreport
There was a problem hiding this comment.
LGTM.
Nit: We seem to have two different patterns emerging for agentless docs. Some use a dedicated 'Agentless Enabled Integration' section, and others bundle it under 'How do I deploy this?'. We should probably standardize this at some point to improve discoverability.
Something other than this ? |
Sorry, I updated the comment but you've been faster: we seem to have two different patterns emerging for agentless docs. Some integrations use a single 'Agentless Enabled Integration' section, and others bundle it under 'How do I deploy this?' with agent and agentless sub-sections. We should probably standardize this at some point to improve discoverability. Not required in this PR, a follow-up one is just fine, it this makes sense. |
💚 Build Succeeded
History
|
|
Package aws - 6.8.0 containing this change is available at https://epr.elastic.co/package/aws/6.8.0/ |
6 participants
Proposed commit message
Enable agentless deployment for aws sqs metrics
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots