Skip to content

[Forescout] Add error.message presence check when removing event.original and update changelog#18514

Closed
akshraj-crest wants to merge 2 commits intoelastic:feature/forescout-0.1.0from
akshraj-crest:update_changelog_resolve_bot_bug
Closed

[Forescout] Add error.message presence check when removing event.original and update changelog#18514
akshraj-crest wants to merge 2 commits intoelastic:feature/forescout-0.1.0from
akshraj-crest:update_changelog_resolve_bot_bug

Conversation

@akshraj-crest
Copy link
Copy Markdown
Contributor

Proposed commit message

Add error.message presence check when removing event.original and update changelog for Forescout

@akshraj-crest akshraj-crest requested a review from a team as a code owner April 20, 2026 03:28
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Reviewers

Buildkite won't run for external contributors automatically; you need to add a comment:

  • /test : will kick off a build in Buildkite.

NOTE: https://github.com/elastic/integrations/blob/main/.buildkite/pull-requests.json contains all those details.

@akshraj-crest akshraj-crest force-pushed the update_changelog_resolve_bot_bug branch from 7c877c3 to 2051e4c Compare April 20, 2026 05:51
@akshraj-crest akshraj-crest requested review from a team as code owners April 20, 2026 05:51
@akshraj-crest akshraj-crest requested review from AndersonQ and andrzej-stencel and removed request for a team April 20, 2026 05:51
@akshraj-crest akshraj-crest requested review from joeypoon, straistaru and tomsonpl and removed request for a team April 20, 2026 05:51
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service Bot commented Apr 20, 2026

💚 CLA has been signed

Comment on lines +472 to +485
- EVAL ratio = 100 * (envoy.http.ingress_http.downstream_rq_2xx / envoy.http.ingress_http.downstream_rq_completed)
- STATS pct = AVG(ratio) | EVAL _gauge_min = 0, _gauge_max = 100, _gauge_goal = 95
metric:
field: pct
label: 2xx / Completed (%)
format:
type: percent
decimals: 1
minimum:
field: _gauge_min
maximum:
field: _gauge_max
goal:
field: _gauge_goal
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low kibana/envoy.yaml:472

The gauge's ESQL query pre-multiplies the ratio by 100 (100 * ...), but the metric format uses type: percent which multiplies by 100 again. This causes the gauge to display "9,500.0%" instead of "95.0%". Either remove the * 100 from the EVAL and update _gauge_max to 1, or change type: percent to number with suffix: " %".

-       - EVAL ratio = 100 * (envoy.http.ingress_http.downstream_rq_2xx / envoy.http.ingress_http.downstream_rq_completed)
+       - EVAL ratio = envoy.http.ingress_http.downstream_rq_2xx / envoy.http.ingress_http.downstream_rq_completed
🤖 Copy this AI Prompt to have your agent fix this:
In file packages/envoyproxy_otel/_dev/shared/kibana/envoy.yaml around lines 472-485:

The gauge's ESQL query pre-multiplies the ratio by 100 (`100 * ...`), but the metric format uses `type: percent` which multiplies by 100 again. This causes the gauge to display "9,500.0%" instead of "95.0%". Either remove the `* 100` from the EVAL and update `_gauge_max` to `1`, or change `type: percent` to `number` with `suffix: " %"`.

Comment on lines +49 to +50
EXISTING=$(gh api "repos/${REPO}/issues/${PR_NUMBER}/comments" \
--jq '[.[] | select(.body | contains("Package docs validation failed"))] | length')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low workflows/notify-package-docs-failure.yml:49

The duplicate-comment check queries repos/${REPO}/issues/${PR_NUMBER}/comments without --paginate. The GitHub API returns only 30 comments per page by default, so if the PR has more than 30 comments and the notification comment is beyond the first page, the check incorrectly reports EXISTING=0 and posts a duplicate. Consider adding --paginate to ensure all comments are searched.

Suggested change
EXISTING=$(gh api "repos/${REPO}/issues/${PR_NUMBER}/comments" \
--jq '[.[] | select(.body | contains("Package docs validation failed"))] | length')
EXISTING=$(gh api --paginate "repos/${REPO}/issues/${PR_NUMBER}/comments" \
🤖 Copy this AI Prompt to have your agent fix this:
In file .github/workflows/notify-package-docs-failure.yml around lines 49-50:

The duplicate-comment check queries `repos/${REPO}/issues/${PR_NUMBER}/comments` without `--paginate`. The GitHub API returns only 30 comments per page by default, so if the PR has more than 30 comments and the notification comment is beyond the first page, the check incorrectly reports `EXISTING=0` and posts a duplicate. Consider adding `--paginate` to ensure all comments are searched.

@andrewkroh andrewkroh added the needs CLA User must sign the Elastic Contributor License before review. label Apr 20, 2026
@osullivandonal
Copy link
Copy Markdown

This PR is huge, it looks like this was a bad rebase? Could we clean up the git history? We should probably close this PR and open a new one with a clean git history.

@akshraj-crest akshraj-crest force-pushed the update_changelog_resolve_bot_bug branch from 2051e4c to 7c877c3 Compare April 20, 2026 14:35
@akshraj-crest
Copy link
Copy Markdown
Contributor Author

Closing this PR for now due to rebase issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs CLA User must sign the Elastic Contributor License before review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants