Skip to content

vsphere: populate ECS source.ip and related.ip from client.ip in log ingest pipelines#18536

Merged
ishleenk17 merged 5 commits intomainfrom
copilot/fix-vsphere-ingest-pipelines
Apr 24, 2026
Merged

vsphere: populate ECS source.ip and related.ip from client.ip in log ingest pipelines#18536
ishleenk17 merged 5 commits intomainfrom
copilot/fix-vsphere-ingest-pipelines

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 21, 2026

vCenter login/logout/failed login/SSH/upload events extract the initiating IP into client.ip but never propagate it to the ECS correlation fields source.ip and related.ip, breaking cross-dataset IP correlation and ECS compliance.

Issue: #18537

Changes

  • ingest_pipeline/login.yml and ingest_pipeline/file.yml: append two processors at the end of each pipeline:
- set:
    field: source.ip
    copy_from: client.ip
    if: ctx.client?.ip != null
- append:
    field: related.ip
    value: "{{client.ip}}"
    allow_duplicates: false
    if: ctx.client?.ip != null
  • test-format-common.log-expected.json: updated all 24 test cases that assert client.ip to also assert source.ip and related.ip.
  • manifest.yml / changelog.yml: bumped package version 1.23.11.24.0.

…g ingest pipelines

Agent-Logs-Url: https://github.com/elastic/integrations/sessions/92c014c0-f3d3-46e0-b39f-4b47b21723b0

Co-authored-by: ishleenk17 <102962586+ishleenk17@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix vSphere integration ingest pipelines for ECS compliance vsphere: populate ECS source.ip and related.ip from client.ip in log ingest pipelines Apr 21, 2026
Copilot AI requested a review from ishleenk17 April 21, 2026 06:11
@andrewkroh andrewkroh added the Integration:vsphere VMware vSphere label Apr 21, 2026
@ishleenk17
Copy link
Copy Markdown
Member

/test

@ishleenk17 ishleenk17 marked this pull request as ready for review April 24, 2026 04:28
@ishleenk17 ishleenk17 requested a review from a team as a code owner April 24, 2026 04:28
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@ishleenk17
Copy link
Copy Markdown
Member

@claude review the PR

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one fix needed before merge: the new 1.24.0 changelog entry links to the wrong PR (#16753 instead of #18536). I left an inline suggestion on that line.

Warning

⚠️ Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • mustache.github.io

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "mustache.github.io"

See Network Configuration for more information.


What is this? | From workflow: Mention in PR

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Comment thread packages/vsphere/changelog.yml Outdated
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ishleenk17
Copy link
Copy Markdown
Member

/test

@ishleenk17 ishleenk17 enabled auto-merge (squash) April 24, 2026 11:04
@ishleenk17
Copy link
Copy Markdown
Member

/test

@ishleenk17 ishleenk17 merged commit 67e97f8 into main Apr 24, 2026
9 checks passed
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

History

cc @ishleenk17 @Copilot

@ishleenk17 ishleenk17 deleted the copilot/fix-vsphere-ingest-pipelines branch April 24, 2026 11:52
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

Package vsphere - 1.24.0 containing this change is available at https://epr.elastic.co/package/vsphere/1.24.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:vsphere VMware vSphere

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants