Skip to content

bk: run faster builds#19006

Merged
v1v merged 1 commit into
elastic:mainfrom
v1v:feature/support-faster-builds-load
May 14, 2026
Merged

bk: run faster builds#19006
v1v merged 1 commit into
elastic:mainfrom
v1v:feature/support-faster-builds-load

Conversation

@v1v
Copy link
Copy Markdown
Member

@v1v v1v commented May 14, 2026

Proposed commit message

Checkout faster when running the loading bk pipeline defined in the catalog-info

Using the spare checkout for the .buildkite folder and the .go-version file

image image

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@v1v v1v requested a review from a team May 14, 2026 12:47
@v1v v1v self-assigned this May 14, 2026
@v1v v1v requested a review from a team as a code owner May 14, 2026 12:47
@v1v v1v enabled auto-merge (squash) May 14, 2026 15:21
Copy link
Copy Markdown
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this plugin looks really interesting!
Thanks!

Maybe it could be added to some other steps in the pipeline.

Comment thread catalog-info.yaml
Comment on lines +49 to +51
paths:
- .buildkite
- .go-version
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, is this plugin just used in the initial "Upload pipeline" step ?

I've triggered a Buildkite build to test this: https://buildkite.com/elastic/integrations/builds/42865

But I guess this is just applied once this PR is merged, so that build did not test anything does 😅

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this plugin just used in the initial "Upload pipeline" step ?

Yes, I've tested it already at https://buildkite.com/elastic/integrations/builds/42859 since I applied the changes manually

But I guess this is just applied once this PR is merged, so that build did not test anything does

correct

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing with this other build: https://buildkite.com/elastic/integrations/builds/42832 1m7s vs 5s

This is a really good improvement, thanks!

Comment thread catalog-info.yaml
Copy link
Copy Markdown
Collaborator

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@v1v v1v merged commit d57619a into elastic:main May 14, 2026
16 checks passed
@mrodm
Copy link
Copy Markdown
Collaborator

mrodm commented May 14, 2026

@v1v Just testing to create a Pull Request adding this plugin into more steps and pipelines , it looks like it could cause issues for those Pull Requests created with branches that start with the merge commit of this PR.

Errors seen:

HEAD is now at d57619a bk: run faster builds (#19006)
Current branch: HEAD
Switched to a new branch 'pr_merge_19015'
New branch created: pr_merge_19015
fatal: refusing to merge unrelated histories
Merge failed: 128
fatal: There is no merge to abort (MERGE_HEAD missing).

Post-checkout hook in this repository merges main branch with the PR branch to ensure that testing also contains the latest changes from main (similar to what Jenkins did here in the past).

I tried to use --allow-unrelated-histories parameter in the merge, but it also failed:

git merge --no-edit --allow-unrelated-histories "${BUILDKITE_COMMIT}"

I did two tests:

Context:

I think this PR should be reverted to check how to apply this change taking into account this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants